code review 36020043: os, os/exec, os/user: add support for GOOS=solaris

os, os/exec, os/user: add support for GOOS=solaris

[aram, 2013-12-10 20:40:34]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2013-12-10 23:45:17]

https://codereview.appspot.com/36020043/diff/180001/src/pkg/os/stat_solaris.go
File src/pkg/os/stat_solaris.go (right):

https://codereview.appspot.com/36020043/diff/180001/src/pkg/os/stat_solaris.g...
src/pkg/os/stat_solaris.go:7: // TODO(dfc) copied from FreeBSD, might be wrong
It's not wrong any more :)

[aram, 2013-12-11 21:27:14]

https://codereview.appspot.com/36020043/diff/180001/src/pkg/os/stat_solaris.go
File src/pkg/os/stat_solaris.go (right):

https://codereview.appspot.com/36020043/diff/180001/src/pkg/os/stat_solaris.g...
src/pkg/os/stat_solaris.go:7: // TODO(dfc) copied from FreeBSD, might be wrong
On 2013/12/10 23:45:17, dfc wrote:
> It's not wrong any more :)

Done.

[minux1, 2013-12-13 07:08:02]

LGTM.

[gobot, 2013-12-20 16:26:20]

Replacing golang-dev with golang-codereviews.

[aram, 2013-12-21 21:48:58]

Hello golang-codereviews@googlegroups.com, dave@cheney.net, minux.ma@gmail.com
(cc: golang-codereviews@googlegroups.com),

Please take another look.

[aram, 2013-12-29 17:45:19]

Hello golang-codereviews@googlegroups.com, dave@cheney.net, minux.ma@gmail.com
(cc: golang-codereviews@googlegroups.com),

Please take another look.

[gobot, 2014-01-07 23:20:11]

R=jsing@google.com (assigned by aram@mgk.ro)

[jsing, 2014-01-08 10:38:34]

LGTM

https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.go
File src/pkg/os/stat_solaris.go (right):

https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.g...
src/pkg/os/stat_solaris.go:1: // Copyright 2013 The Go Authors. All rights
reserved.
Copyright years are not updated - please revert this, given that the file is
predominantly a copy.

[dave_cheney.net, 2014-01-08 11:07:09]

> On 8 Jan 2014, at 21:38, jsing@google.com wrote:
> 
> LGTM
> 
> 
>
https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.go
> File src/pkg/os/stat_solaris.go (right):
> 
>
https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.g...
> src/pkg/os/stat_solaris.go:1: // Copyright 2013 The Go Authors. All
> rights reserved.
> Copyright years are not updated - please revert this, given that the
> file is predominantly a copy.

Id like to disagree, this is a new file, even if 99% of it is a copy from
someplace else. 
> 
> https://codereview.appspot.com/36020043/

[jsing, 2014-01-08 11:30:13]

On 2014/01/08 11:07:09, dfc wrote:
> 
> > On 8 Jan 2014, at 21:38, mailto:jsing@google.com wrote:
> > 
> > LGTM
> > 
> > 
> >
> https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.go
> > File src/pkg/os/stat_solaris.go (right):
> > 
> >
>
https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.g...
> > src/pkg/os/stat_solaris.go:1: // Copyright 2013 The Go Authors. All
> > rights reserved.
> > Copyright years are not updated - please revert this, given that the
> > file is predominantly a copy.
> 
> Id like to disagree, this is a new file, even if 99% of it is a copy from
> someplace else.

It may be a new file, however it is a derivative work and as I understand it,
the original copyright year applies.

[dave_cheney.net, 2014-01-08 11:33:04]

Sure. But I can cite many examples in the current code base that can support
*both* of our positions. 

> On 8 Jan 2014, at 22:30, jsing@google.com wrote:
> 
>> On 2014/01/08 11:07:09, dfc wrote:
>> 
>> > On 8 Jan 2014, at 21:38, mailto:jsing@google.com wrote:
>> >
>> > LGTM
>> >
>> >
>> >
> 
>
https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.go
>> > File src/pkg/os/stat_solaris.go (right):
>> >
>> >
> 
>
https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.g...
>> > src/pkg/os/stat_solaris.go:1: // Copyright 2013 The Go Authors. All
>> > rights reserved.
>> > Copyright years are not updated - please revert this, given that the
>> > file is predominantly a copy.
> 
>> Id like to disagree, this is a new file, even if 99% of it is a copy
> from
>> someplace else.
> 
> It may be a new file, however it is a derivative work and as I
> understand it, the original copyright year applies.
> 
> https://codereview.appspot.com/36020043/
> 
> -- 
> You received this message because you are subscribed to the Google Groups
"golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

[aram, 2014-01-09 15:09:16]

https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.go
File src/pkg/os/stat_solaris.go (right):

https://codereview.appspot.com/36020043/diff/340001/src/pkg/os/stat_solaris.g...
src/pkg/os/stat_solaris.go:1: // Copyright 2013 The Go Authors. All rights
reserved.
On 2014/01/08 10:38:35, jsing wrote:
> Copyright years are not updated - please revert this, given that the file is
> predominantly a copy.

Done.

[aram, 2014-01-09 15:11:02]

Hello golang-codereviews@googlegroups.com, dave@cheney.net, minux.ma@gmail.com,
gobot@golang.org, jsing@google.com (cc: golang-codereviews@googlegroups.com),

Please take another look.

[jsing, 2014-01-09 15:48:13]

LGTM

[jsing, 2014-01-09 15:49:49]

*** Submitted as https://code.google.com/p/go/source/detail?r=99a1e180eda3 ***

os, os/exec, os/user: add support for GOOS=solaris

R=golang-codereviews, dave, minux.ma, gobot, jsing
CC=golang-codereviews
https://codereview.appspot.com/36020043

Committer: Joel Sing <jsing@google.com>