cmd/cgo: use __gcc_struct__ for go exported functions

cmd/cgo: use __gcc_struct__ for go exported functions

Fixes issue 6833

[minux1, 2013-12-02 05:27:36]

LGTM.

[brainman, 2013-12-03 02:04:28]

minux already LGTMed it, but I am mailing this out for others. Just in case.

Alex

[minux1, 2013-12-03 02:09:01]

R: +iant
CC: +golang-dev

[iant, 2013-12-03 17:33:24]

https://codereview.appspot.com/35790045/diff/20001/misc/cgo/test/issue6833_c.c
File misc/cgo/test/issue6833_c.c (right):

https://codereview.appspot.com/35790045/diff/20001/misc/cgo/test/issue6833_c....
misc/cgo/test/issue6833_c.c:9: return GoIssue6833Func( aui, aull);
Remove the space after the right parenthesis.

https://codereview.appspot.com/35790045/diff/20001/src/cmd/cgo/out.go
File src/cmd/cgo/out.go (right):

https://codereview.appspot.com/35790045/diff/20001/src/cmd/cgo/out.go#newcode620
src/cmd/cgo/out.go:620: s := ""
Now that this is in its own function, I think it would be clearer if it were
something more like
    s := "__attribute__((__packed"
    if ... {
        s += ", __gcc_struct__"
    }
    return s + "))"

[brainman, 2013-12-04 01:55:07]

Hello minux.ma@gmail.com, iant@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[brainman, 2013-12-04 01:55:12]

https://codereview.appspot.com/35790045/diff/20001/misc/cgo/test/issue6833_c.c
File misc/cgo/test/issue6833_c.c (right):

https://codereview.appspot.com/35790045/diff/20001/misc/cgo/test/issue6833_c....
misc/cgo/test/issue6833_c.c:9: return GoIssue6833Func( aui, aull);
On 2013/12/03 17:33:24, iant wrote:
> Remove the space after the right parenthesis.

Done.

https://codereview.appspot.com/35790045/diff/20001/src/cmd/cgo/out.go
File src/cmd/cgo/out.go (right):

https://codereview.appspot.com/35790045/diff/20001/src/cmd/cgo/out.go#newcode620
src/cmd/cgo/out.go:620: s := ""
On 2013/12/03 17:33:24, iant wrote:
> Now that this is in its own function, I think it would be clearer if it were
> something more like
>     s := "__attribute__((__packed"
>     if ... {
>         s += ", __gcc_struct__"
>     }
>     return s + "))"

It needs to be

s := "__attribute__((__packed__"

not

s := "__attribute__((__packed"

but otherwise done.

[iant, 2013-12-04 02:09:57]

LGTM

[brainman, 2013-12-10 00:30:21]

*** Submitted as https://code.google.com/p/go/source/detail?r=c34866d8a2e2 ***

cmd/cgo: use __gcc_struct__ for go exported functions

Fixes issue 6833

R=minux.ma, iant
CC=golang-dev
https://codereview.appspot.com/35790045