Issue 3481042: code review 3481042: crypto/tls: add *Config argument to Dial

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3481042: code review 3481042: crypto/tls: add *Config argument to Dial (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by rsc

Modified:
13 years, 4 months ago

Reviewers:

CC:
agl1, golang-dev

Visibility:
Public.

Description

crypto/tls: add *Config argument to Dial Document undocumented exported names. Allow nil Rand, Time, RootCAs in Config. Fixes issue 1248.

Patch Set 2 : code review 3481042: crypto/tls: add *Config argument to Dial #

Patch Set 3 : code review 3481042: crypto/tls: add *Config argument to Dial #

Total comments: 1

Patch Set 4 : code review 3481042: crypto/tls: add *Config argument to Dial #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+109 lines, -40 lines)			Patch
M	src/pkg/crypto/tls/ca_set.go	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/crypto/tls/common.go	View	1 2 3	5 chunks	+58 lines, -20 lines	0 comments	Download
M	src/pkg/crypto/tls/handshake_client.go	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	src/pkg/crypto/tls/handshake_server.go	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/pkg/crypto/tls/tls.go	View		5 chunks	+39 lines, -9 lines	0 comments	Download
M	src/pkg/http/client.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/websocket/client.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello agl1 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

13 years, 4 months ago (2010-12-07 20:52:04 UTC) #1

agl1

LGTM http://codereview.appspot.com/3481042/diff/6001/src/pkg/crypto/tls/common.go File src/pkg/crypto/tls/common.go (right): http://codereview.appspot.com/3481042/diff/6001/src/pkg/crypto/tls/common.go#newcode106 src/pkg/crypto/tls/common.go:106: // that clients use when verifying server certificates. ...

13 years, 4 months ago (2010-12-07 20:56:48 UTC) #2

rsc

13 years, 4 months ago (2010-12-07 21:15:18 UTC) #4

*** Submitted as b0b1db081ca8 ***

crypto/tls: add *Config argument to Dial

Document undocumented exported names.
Allow nil Rand, Time, RootCAs in Config.

Fixes issue 1248.

R=agl1
CC=golang-dev
http://codereview.appspot.com/3481042

Expand All Messages | Collapse All Messages