code review 3473041: builder: Allow buildroot to be passed as command-line a...

builder: Allow buildroot to be passed as command-line argument

[adg, 2010-12-05 23:17:46]

Thanks. Looks good, there are only formatting issues.

http://codereview.appspot.com/3473041/diff/1/misc/dashboard/builder/main.go
File misc/dashboard/builder/main.go (right):

http://codereview.appspot.com/3473041/diff/1/misc/dashboard/builder/main.go#n...
misc/dashboard/builder/main.go:65: goroot = path.Join(*buildroot, "goroot")
Remove whitespace lines before and after this line, and run gofmt on the whole
file.

[dho, 2010-12-05 23:19:30]

Hello adg (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[dho, 2010-12-05 23:20:42]

2010/12/5  <adg@golang.org>:
> Thanks. Looks good, there are only formatting issues.
>
>
> http://codereview.appspot.com/3473041/diff/1/misc/dashboard/builder/main.go
> File misc/dashboard/builder/main.go (right):
>
>
http://codereview.appspot.com/3473041/diff/1/misc/dashboard/builder/main.go#n...
> misc/dashboard/builder/main.go:65: goroot = path.Join(*buildroot,
> "goroot")
> Remove whitespace lines before and after this line, and run gofmt on the
> whole file.

Done. Was under the impression that the codereview extension used to
run gofmt on all files before they were submitted and yell at you if
they'd make changes. Guess that's not the case anymore. :S

> http://codereview.appspot.com/3473041/
>

[adg, 2010-12-05 23:31:50]

LGTM

[adg, 2010-12-05 23:34:45]

*** Submitted as http://code.google.com/p/go/source/detail?r=02d4c067277f ***

builder: Allow buildroot to be passed as command-line argument

R=adg
CC=golang-dev
http://codereview.appspot.com/3473041

Committer: Andrew Gerrand <adg@golang.org>