Issue 3460043: code review 3460043: html: handle unexpected EOF during parsing.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3460043: code review 3460043: html: handle unexpected EOF during parsing. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by nigeltao

Modified:
13 years, 5 months ago

Reviewers:
nigeltao_gnome

CC:
gri, golang-dev

Visibility:
Public.

Description

html: handle unexpected EOF during parsing. This lets us parse HTML like "<html>foo".

Patch Set 2 : code review 3460043: html: handle unexpected EOF during parsing. #

Total comments: 2

Patch Set 3 : code review 3460043: html: handle unexpected EOF during parsing. #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -24 lines)			Patch
	M	src/pkg/html/parse.go	View	1 2	13 chunks	+42 lines, -17 lines	0 comments	Download
	M	src/pkg/html/parse_test.go	View		2 chunks	+6 lines, -7 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

nigeltao

Hello gri (cc: golang-dev@googlegroups.com), I'd like you to review this change.

13 years, 5 months ago (2010-12-07 04:09:46 UTC) #1

nigeltao

http://codereview.appspot.com/3460043/diff/2001/src/pkg/html/parse_test.go File src/pkg/html/parse_test.go (right): http://codereview.appspot.com/3460043/diff/2001/src/pkg/html/parse_test.go#newcode127 src/pkg/html/parse_test.go:127: for i := 0; i < 19; i++ { ...

13 years, 5 months ago (2010-12-07 04:10:56 UTC) #2

gri

LGTM http://codereview.appspot.com/3460043/diff/2001/src/pkg/html/parse.go File src/pkg/html/parse.go (right): http://codereview.appspot.com/3460043/diff/2001/src/pkg/html/parse.go#newcode156 src/pkg/html/parse.go:156: implied = true Is this so that the ...

13 years, 5 months ago (2010-12-07 19:33:57 UTC) #3

nigeltao

*** Submitted as http://code.google.com/p/go/source/detail?r=ed0d2ba360d9 *** html: handle unexpected EOF during parsing. This lets us parse ...

13 years, 5 months ago (2010-12-07 21:59:29 UTC) #4

nigeltao_gnome

13 years, 5 months ago (2010-12-07 22:00:21 UTC) #5

On 8 December 2010 06:33,  <gri@golang.org> wrote:
> LGTM
>
> http://codereview.appspot.com/3460043/diff/2001/src/pkg/html/parse.go
> File src/pkg/html/parse.go (right):
>
>
http://codereview.appspot.com/3460043/diff/2001/src/pkg/html/parse.go#newcode156
> src/pkg/html/parse.go:156: implied = true
> Is this so that the cleanup loop (430ff) is terminating? Or how can one
> get here otherwise? (the main read loop returns upon error, except for
> EOF). Could use a comment.
>
> http://codereview.appspot.com/3460043/

Yeah, ErrorToken means EOF and only EOF, inside an insertionMode. I've
added a comment.

Expand All Messages | Collapse All Messages