Issue 3442041: code review 3442041: doc/install: describe GOHOSTOS and GOHOSTARCH

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3442041: code review 3442041: doc/install: describe GOHOSTOS and GOHOSTARCH (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by adg

Modified:
14 years, 3 months ago

Reviewers:

CC:
rsc, peterGo, golang-dev

Visibility:
Public.

Description

doc/install: describe GOHOSTOS and GOHOSTARCH Fixes issue 1303.

Patch Set 1 #

Total comments: 4

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -3 lines)			Patch
	M	doc/install.html	View		3 chunks	+19 lines, -3 lines	4 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 3 months ago (2010-12-03 04:40:26 UTC) #1

peterGo

http://codereview.appspot.com/3442041/diff/1/doc/install.html File doc/install.html (right): http://codereview.appspot.com/3442041/diff/1/doc/install.html#newcode393 doc/install.html:393: <code>$GOHOSTARCH</code> to <code>arm</code> on an Intel system. The term ...

14 years, 3 months ago (2010-12-03 14:38:49 UTC) #2

rsc1

LGTM http://codereview.appspot.com/3442041/diff/1/doc/install.html File doc/install.html (right): http://codereview.appspot.com/3442041/diff/1/doc/install.html#newcode300 doc/install.html:300: The Go compilation environment can be customized by ...

14 years, 3 months ago (2010-12-03 15:03:40 UTC) #3

adg

14 years, 3 months ago (2010-12-05 03:04:15 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=d5f6d3b55899 ***

doc/install: describe GOHOSTOS and GOHOSTARCH

Fixes issue 1303.

R=rsc, PeterGo
CC=golang-dev
http://codereview.appspot.com/3442041

Committer: Andrew Gerrand <adg@golang.org>

Expand All Messages | Collapse All Messages