Issue 3420041: code review 3420041: go_spec: fixed a couple omissions/type errors

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3420041: code review 3420041: go_spec: fixed a couple omissions/type errors (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by gri

Modified:
14 years, 3 months ago

Reviewers:

CC:
r, rsc, iant, ken2, golang-dev

Visibility:
Public.

Description

go_spec: fixed a couple omissions/type errors - use math.Sqrt instead of Math.sqrt - use float64 for Point fields to match math.Sqrt - distinguish between Point and Point3D for clarity - add alignment sizes for complex types

Patch Set 1 #

Patch Set 2 : code review 3420041: go_spec: fixed a couple omissions/type errors #

Patch Set 3 : code review 3420041: go_spec: fixed a couple omissions/type errors #

Patch Set 4 : code review 3420041: go_spec: fixed a couple omissions/type errors #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -22 lines)			Patch
	M	doc/go_spec.html	View	1 2	9 chunks	+23 lines, -22 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gri

Hello r, rsc, iant, ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 3 months ago (2010-12-02 19:29:21 UTC) #1

gri

14 years, 3 months ago (2010-12-02 20:32:21 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=061e47ba45e6 ***

go_spec: fixed a couple omissions/type errors

- use math.Sqrt instead of Math.sqrt
- use float64 for Point fields to match math.Sqrt
- distinguish between Point and Point3D for clarity
- add alignment sizes for complex types

R=r, rsc, iant, ken2
CC=golang-dev
http://codereview.appspot.com/3420041

Expand All Messages | Collapse All Messages