Issue 3416042: code review 3416042: A+C: added Jamie Gennis

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3416042: code review 3416042: A+C: added Jamie Gennis (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by gri

Modified:
14 years, 3 months ago

Reviewers:
iant2

CC:
iant, r, golang-dev

Visibility:
Public.

Description

A+C: added Jamie Gennis

Patch Set 1 #

Patch Set 2 : code review 3416042: A+C: added Jamie Gennis #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	CONTRIBUTORS	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gri

Hello iant (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 3 months ago (2010-12-02 18:07:23 UTC) #1

gri

*** Submitted as http://code.google.com/p/go/source/detail?r=9618d167441c *** A+C: added Jamie Gennis R=iant, r CC=golang-dev http://codereview.appspot.com/3416042

14 years, 3 months ago (2010-12-02 18:42:02 UTC) #3

iant2

14 years, 3 months ago (2010-12-02 18:52:28 UTC) #4

LGTM

gri@golang.org writes:

> Reviewers: iant,
>
> Message:
> Hello iant (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> A+C: added Jamie Gennis
>
> Please review this at http://codereview.appspot.com/3416042/
>
> Affected files:
>   M CONTRIBUTORS
>
>
> Index: CONTRIBUTORS
> ===================================================================
> --- a/CONTRIBUTORS
> +++ b/CONTRIBUTORS
> @@ -96,6 +96,7 @@
>  James Meneghello <rawrz0r@gmail.com>
>  James Toy <nil@opensesame.st>
>  James Whitehead <jnwhiteh@gmail.com>
> +Jamie Gennis <jgennis@google.com>
>  Jan H. Hosang <jan.hosang@gmail.com>
>  Jan Mercl <befelemepeseveze@gmail.com>
>  Jim McGrath <jimmc2@gmail.com>

Expand All Messages | Collapse All Messages