Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9)

Issue 3385041: code review 3385041: template: implement multi-word variable instantation fo... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 3 months ago by r
Modified:
14 years, 3 months ago
Reviewers:
gri
CC:
rsc, gri, golang-dev
Visibility:
Public.

Description

template: implement multi-word variable instantation for formatters. Before one could say {field} or {field|formatter} Now one can also say {field1 field2 field3} or {field1 field2 field3|formatter} and the fields are passed as successive arguments to the formatter, analogous to fmt.Print.

Patch Set 1 #

Patch Set 2 : code review 3385041: template: implement multi-word variable instantation fo... #

Patch Set 3 : code review 3385041: template: implement multi-word variable instantation fo... #

Patch Set 4 : code review 3385041: template: implement multi-word variable instantation fo... #

Patch Set 5 : code review 3385041: template: implement multi-word variable instantation fo... #

Patch Set 6 : code review 3385041: template: implement multi-word variable instantation fo... #

Patch Set 7 : code review 3385041: template: implement multi-word variable instantation fo... #

Patch Set 8 : code review 3385041: template: implement multi-word variable instantation fo... #

Patch Set 9 : code review 3385041: template: implement multi-word variable instantation fo... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -17 lines) Patch
M src/pkg/template/template.go View 1 2 7 chunks +26 lines, -17 lines 0 comments Download
M src/pkg/template/template_test.go View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 3
r
Hello rsc, gri (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 3 months ago (2010-12-01 22:27:22 UTC) #1
gri
LGTM - gri On Wed, Dec 1, 2010 at 2:27 PM, <r@golang.org> wrote: > Reviewers: ...
14 years, 3 months ago (2010-12-02 00:28:54 UTC) #2
r
14 years, 3 months ago (2010-12-02 01:10:42 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=e7e503c689aa ***

template: implement multi-word variable instantation for formatters.
Before one could say
	{field}
or
	{field|formatter}
Now one can also say
	{field1 field2 field3}
or
	{field1 field2 field3|formatter}
and the fields are passed as successive arguments to the formatter,
analogous to fmt.Print.

R=rsc, gri
CC=golang-dev
http://codereview.appspot.com/3385041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b