code review 33810044: go.net/publicsuffix: specify format of domains.

go.net/publicsuffix: add new eTLD test for IDNs.

[volker.dobler, 2013-11-27 10:24:26]

Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.net/

[nigeltao, 2013-11-28 03:11:47]

CC'ing bradfitz for all things net/http in the standard library.

https://codereview.appspot.com/33810044/diff/40001/publicsuffix/list.go
File publicsuffix/list.go (left):

https://codereview.appspot.com/33810044/diff/40001/publicsuffix/list.go#oldco...
publicsuffix/list.go:10: // TODO: specify case sensitivity and leading/trailing
dot behavior for
There's a corresponding TODO in the standard library's net/http/cookiejar
package's PublicSuffixList type. This package's List type is an implementation
of the std lib's PublicSuffixList interface, and the interface defines the
semantics wrt lowercase, etc. I don't think we can resolve this TODO without
resolving the one in the std lib first.

[volker.dobler, 2013-11-28 08:43:43]

https://codereview.appspot.com/33810044/diff/40001/publicsuffix/list.go
File publicsuffix/list.go (left):

https://codereview.appspot.com/33810044/diff/40001/publicsuffix/list.go#oldco...
publicsuffix/list.go:10: // TODO: specify case sensitivity and leading/trailing
dot behavior for
On 2013/11/28 03:11:47, nigeltao wrote:
> There's a corresponding TODO in the standard library's net/http/cookiejar
> package's PublicSuffixList type. This package's List type is an implementation
> of the std lib's PublicSuffixList interface, and the interface defines the
> semantics wrt lowercase, etc. I don't think we can resolve this TODO without
> resolving the one in the std lib first.

Sorry, overlooked that one.

I'll propose the following once the tree is open again and the big stuff
is committed:
package cookiejar
type PublicSuffixList {
    // PublicSuffix returns the public suffix of domain.
    // 
    // Domain may be upper or lower case and may start or end with a dot.
    // The returned public suffix will be lowercase with the optional dots
removed.
    // A non-punycoded internationalized domain name must be encoded as UTF-8
    // and the returned public suffix will be non-punycoded UTF-8.
    // If domain is malformed (e.g. an IP address) the returned public suffix is
empty.
    PublicSuffix(domain string) string
}
Rational: PublicSuffix does not return an error so it should
"do the right thing" in almost all cases.

[gobot, 2013-12-20 16:26:07]

Replacing golang-dev with golang-codereviews.

[nigeltao, 2014-02-18 05:43:04]

LGTM.

[nigeltao, 2014-02-18 05:43:58]

*** Submitted as
https://code.google.com/p/go/source/detail?r=89dbba2db2d4&repo=net ***

go.net/publicsuffix: add new eTLD test for IDNs.

LGTM=nigeltao
R=nigeltao
CC=bradfitz, golang-codereviews
https://codereview.appspot.com/33810044

Committer: Nigel Tao <nigeltao@golang.org>