code review 3378041: template: change the signature of formatters for future...

template: change the signature of formatters for future development.
Make them more like Printf, with a ... final argument.  This breaks
code with existing formatters but not the templates that use them.

[r, 2010-12-01 20:55:41]

Hello rsc, gri (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[gri, 2010-12-01 21:29:18]

LGTM
- gri

On Wed, Dec 1, 2010 at 12:55 PM, <r@golang.org> wrote:

> Reviewers: rsc, gri,
>
> Message:
> Hello rsc, gri (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> template: change the signature of formatters for future development.
> Make them more like Printf, with a ... final argument.  This breaks
> code with existing formatters but not the templates that use them.
>
> Please review this at http://codereview.appspot.com/3378041/
>
> Affected files:
>  M src/cmd/godoc/godoc.go
>  M src/cmd/godoc/main.go
>  M src/pkg/template/format.go
>  M src/pkg/template/template.go
>  M src/pkg/template/template_test.go
>
>
>

[rsc1, 2010-12-01 21:32:10]

LGTM

[r, 2010-12-01 21:33:53]

*** Submitted as http://code.google.com/p/go/source/detail?r=2c2be793120e ***

template: change the signature of formatters for future development.
Make them more like Printf, with a ... final argument.  This breaks
code with existing formatters but not the templates that use them.

R=rsc, gri
CC=golang-dev
http://codereview.appspot.com/3378041