Issue 3364041: code review 3364041: utf8: make EncodeRune's destination the first argument.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3364041: code review 3364041: utf8: make EncodeRune's destination the first argument. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by agl1

Modified:
14 years, 3 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

utf8: make EncodeRune's destination the first argument.

Patch Set 1 #

Patch Set 2 : code review 3364041: utf8: make EncodeRune's destination the first argument. #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -233 lines)			Patch
M	src/pkg/bufio/bufio.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/bufio/bufio_test.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/bytes/buffer.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/bytes/buffer_test.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/bytes/bytes.go	View	1 chunk	+1 line, -1 line	0 comments	Download
R	src/pkg/crypto/block/cbc_aes_test.go	View	1 chunk	+0 lines, -102 lines	0 comments	Download
R	src/pkg/crypto/block/ctr_aes_test.go	View	1 chunk	+0 lines, -110 lines	0 comments	Download
M	src/pkg/fmt/print.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/html/escape.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/json/decode.go	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/regexp/regexp.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/strings/strings.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/utf8/utf8.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/utf8/utf8_test.go	View	3 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

agl1

I don't know if you actually want to take an API breaking change to do ...

14 years, 3 months ago (2010-11-30 21:46:32 UTC) #1

agl1

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 3 months ago (2010-11-30 21:59:42 UTC) #3

agl1

*** Submitted as http://code.google.com/p/go/source/detail?r=35a3729e9a5c *** utf8: make EncodeRune's destination the first argument. R=r CC=golang-dev http://codereview.appspot.com/3364041

14 years, 3 months ago (2010-11-30 21:59:49 UTC) #4

Submitted.

Expand All Messages | Collapse All Messages