Issue 3359041: code review 3359041: strconv: Atof on Infs and NaNs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3359041: code review 3359041: strconv: Atof on Infs and NaNs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by r

Modified:
14 years, 3 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Patch Set 2 : code review 3359041: strconv: Atof on Infs and NaNs #

Total comments: 2

Patch Set 3 : code review 3359041: strconv: Atof on Infs and NaNs #

Patch Set 4 : code review 3359041: strconv: Atof on Infs and NaNs #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -0 lines)			Patch
	M	src/pkg/strconv/atof.go	View	1 2 3	3 chunks	+42 lines, -0 lines	0 comments	Download
	M	src/pkg/strconv/atof_test.go	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 3 months ago (2010-11-30 19:39:50 UTC) #1

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 3 months ago (2010-11-30 20:34:34 UTC) #2

rsc1

LGTM http://codereview.appspot.com/3359041/diff/3001/src/pkg/strconv/atof.go File src/pkg/strconv/atof.go (right): http://codereview.appspot.com/3359041/diff/3001/src/pkg/strconv/atof.go#newcode27 src/pkg/strconv/atof.go:27: c1 := s1[i] &^ ' ' only works ...

14 years, 3 months ago (2010-11-30 20:37:52 UTC) #3

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 3 months ago (2010-11-30 20:46:21 UTC) #4

14 years, 3 months ago (2010-11-30 20:53:48 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=949e37bd83f4 ***

strconv: Atof on Infs and NaNs

R=rsc
CC=golang-dev
http://codereview.appspot.com/3359041

Expand All Messages | Collapse All Messages