Issue 3319042: code review 3319042: fmt: allow "% X" as well as "% x"

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3319042: code review 3319042: fmt: allow "% X" as well as "% x" (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by r

Modified:
14 years, 3 months ago

Reviewers:

CC:
rsc, cw, peterGo, golang-dev

Visibility:
Public.

Patch Set 2 : code review 3319042: fmt: allow "% X" as well as "% x" #

Patch Set 3 : code review 3319042: fmt: allow "% X" as well as "% x" #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
M	src/pkg/fmt/doc.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/fmt/fmt_test.go	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/pkg/fmt/format.go	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 3 months ago (2010-11-26 04:14:21 UTC) #1

http://codereview.appspot.com/3319042/diff/1/src/pkg/fmt/fmt_test.go File src/pkg/fmt/fmt_test.go (right): http://codereview.appspot.com/3319042/diff/1/src/pkg/fmt/fmt_test.go#newcode125 src/pkg/fmt/fmt_test.go:125: {"% X", []byte("ab\xff"), "61 62 63 FF"}, shouldn't that ...

14 years, 3 months ago (2010-11-28 03:52:32 UTC) #2

peterGo

14 years, 3 months ago (2010-11-28 05:20:00 UTC) #3

Hello rsc, cw, PeterGo (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 3 months ago (2010-11-28 16:43:43 UTC) #4

14 years, 3 months ago (2010-11-29 15:30:43 UTC) #7

*** Submitted as http://code.google.com/p/go/source/detail?r=cbfea31a4187 ***

fmt: allow "% X" as well as "% x"

R=rsc, cw, PeterGo
CC=golang-dev
http://codereview.appspot.com/3319042

Expand All Messages | Collapse All Messages