Issue 3306042: code review 3306042: [68]l: correct dwarf location for globals and ranges fo...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3306042: code review 3306042: [68]l: correct dwarf location for globals and ranges fo... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by lvd

Modified:
14 years, 3 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

[68]l: correct dwarf location for globals and ranges for arrays.

Patch Set 2 : code review 3306042: [68]l: correct dwarf location for globals and ranges fo... #

Patch Set 3 : code review 3306042: [68]l: correct dwarf location for globals and ranges fo... #

Total comments: 3

Patch Set 4 : code review 3306042: [68]l: correct dwarf location for globals and ranges fo... #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+96 lines, -16 lines)			Patch
	M	src/cmd/ld/dwarf.c	View	1 2 3	26 chunks	+96 lines, -16 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

lvd

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 3 months ago (2010-11-29 17:56:21 UTC) #1

rsc1

LGTM http://codereview.appspot.com/3306042/diff/6001/src/cmd/ld/dwarf.c File src/cmd/ld/dwarf.c (right): http://codereview.appspot.com/3306042/diff/6001/src/cmd/ld/dwarf.c#newcode507 src/cmd/ld/dwarf.c:507: DWDie *r; add blank line after this one ...

14 years, 3 months ago (2010-11-29 17:58:46 UTC) #2

lvd

14 years, 3 months ago (2010-11-29 18:25:39 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=4185a5f8ced2 ***

[68]l: correct dwarf location for globals and ranges for arrays.

R=rsc
CC=golang-dev
http://codereview.appspot.com/3306042

Expand All Messages | Collapse All Messages