Issue 3283042: code review 3283042: Fixed parser.ParseFile invocation in exp/eval

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3283042: code review 3283042: Fixed parser.ParseFile invocation in exp/eval (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by anschelsc

Modified:
14 years, 3 months ago

Reviewers:
rsc

CC:
golang-dev, nigeltao

Visibility:
Public.

Description

Fixed parser.ParseFile invocation in exp/eval The signature of this function changed some time ago, is anyone maintaining this code?

Patch Set 1 #

Patch Set 2 : code review 3283042: Fixed parser.ParseFile invocation in exp/eval #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/exp/eval/main.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

anschelsc

Hello golang-dev@googlegroups.com, I'd like you to review this change.

14 years, 3 months ago (2010-11-28 19:52:11 UTC) #1

nigeltao

LGTM. pkg/exp/eval/main.go isn't part of any automated build.

14 years, 3 months ago (2010-11-28 22:25:23 UTC) #2

nigeltao

*** Submitted as http://code.google.com/p/go/source/detail?r=39e56a806cdc *** exp/eval: build fix for parser.ParseFile API change. R=golang-dev, nigeltao CC=golang-dev ...

14 years, 3 months ago (2010-11-28 22:25:37 UTC) #3

rsc

14 years, 3 months ago (2010-11-29 17:19:09 UTC) #4

> pkg/exp/eval/main.go isn't part of any automated build.

can we please fix that?

Expand All Messages | Collapse All Messages