code review 3280045: fmt.Scan: accept Inf and NaN

fmt.Scan: accept Inf and NaN
Fixes issue 1308.

[r, 2010-11-30 19:59:31]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc1, 2010-11-30 20:39:11]

http://codereview.appspot.com/3280045/diff/1/src/pkg/fmt/scan.go
File src/pkg/fmt/scan.go (right):

http://codereview.appspot.com/3280045/diff/1/src/pkg/fmt/scan.go#newcode550
src/pkg/fmt/scan.go:550: s.accept(sign)
move down after nan

http://codereview.appspot.com/3280045/diff/1/src/pkg/fmt/scan_test.go
File src/pkg/fmt/scan_test.go (right):

http://codereview.appspot.com/3280045/diff/1/src/pkg/fmt/scan_test.go#newcode409
src/pkg/fmt/scan_test.go:409: func TestNaN(t *testing.T) {
lot of code.  can just add to the scanTests table, no?

[r, 2010-11-30 20:41:47]

Hello rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc1, 2010-11-30 20:46:50]

LGTM

fine as is but seems javaesque

http://codereview.appspot.com/3280045/diff/6001/src/pkg/fmt/scan_test.go
File src/pkg/fmt/scan_test.go (right):

http://codereview.appspot.com/3280045/diff/6001/src/pkg/fmt/scan_test.go#newc...
src/pkg/fmt/scan_test.go:455: verifyInf("inf", t)
still looks like a range loop waiting to happen

[r2, 2010-11-30 20:47:24]

On Nov 30, 2010, at 12:39 PM, rsc@google.com wrote:

> 
> http://codereview.appspot.com/3280045/diff/1/src/pkg/fmt/scan.go
> File src/pkg/fmt/scan.go (right):
> 
> http://codereview.appspot.com/3280045/diff/1/src/pkg/fmt/scan.go#newcode550
> src/pkg/fmt/scan.go:550: s.accept(sign)
> move down after nan
> 
> http://codereview.appspot.com/3280045/diff/1/src/pkg/fmt/scan_test.go
> File src/pkg/fmt/scan_test.go (right):
> 
>
http://codereview.appspot.com/3280045/diff/1/src/pkg/fmt/scan_test.go#newcode409
> src/pkg/fmt/scan_test.go:409: func TestNaN(t *testing.T) {
> lot of code.  can just add to the scanTests table, no?

i tried that but reflect.DeepEqual doesn't work on NaN and Inf so a lot of
fussing is necessary. it seemed simpler this way. see new version of tests - not
so bad

[r, 2010-11-30 20:59:54]

*** Submitted as http://code.google.com/p/go/source/detail?r=a07fbf2249cf ***

fmt.Scan: accept Inf and NaN
Fixes issue 1308.

R=rsc, r2
CC=golang-dev
http://codereview.appspot.com/3280045