Issue 3271041: code review 3271041: runtime: fix SysFree to really free memory on Windows

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3271041: code review 3271041: runtime: fix SysFree to really free memory on Windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by brainman

Modified:
14 years, 3 months ago

Reviewers:

CC:
golang-dev, peterGo, iant

Visibility:
Public.

Description

runtime: fix SysFree to really free memory on Windows Fixes issue 1294.

Patch Set 2 : code review 3271041: runtime: fix SysFree to really free memory on Windows #

Patch Set 3 : code review 3271041: runtime: fix SysFree to really free memory on Windows #

Total comments: 1

Patch Set 4 : code review 3271041: runtime: fix SysFree to really free memory on Windows #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -2 lines)			Patch
	M	src/pkg/runtime/windows/mem.c	View		2 chunks	+21 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change.

14 years, 3 months ago (2010-11-23 05:48:44 UTC) #1

iant

http://codereview.appspot.com/3271041/diff/6001/src/pkg/runtime/windows/mem.c File src/pkg/runtime/windows/mem.c (right): http://codereview.appspot.com/3271041/diff/6001/src/pkg/runtime/windows/mem.c#newcode51 src/pkg/runtime/windows/mem.c:51: r = (uintptr)runtime·stdcall(runtime·VirtualFree, 3, v, 0, MEM_RELEASE); You seem ...

14 years, 3 months ago (2010-11-23 16:38:17 UTC) #3

brainman

14 years, 3 months ago (2010-11-24 00:47:42 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=b2a35b558ce9 ***

runtime: fix SysFree to really free memory on Windows

Fixes issue 1294.

R=golang-dev, PeterGo, iant
CC=golang-dev
http://codereview.appspot.com/3271041

Expand All Messages | Collapse All Messages