code review 3217042: errchk: accept multiple source files

errchk: accept multiple source files

[ejsherry, 2010-11-20 02:58:32]

Hello rsc, iant (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[ejsherry, 2010-11-20 03:01:01]

Tested against 6g and gccgo.

[rsc, 2010-12-07 17:03:00]

I'd prefer not to change the syntax when moving
from one file to multiple files.  Why not instead 
count backward from the end as long as the argument
matches /\.go$/?

[ejsherry, 2010-12-07 20:25:02]

On 2010/12/07 17:03:00, rsc wrote:
> I'd prefer not to change the syntax when moving
> from one file to multiple files.  Why not instead 
> count backward from the end as long as the argument
> matches /\.go$/?

Done.
Makes sense; using -- was ugly.

PTAL

[rsc1, 2010-12-07 20:27:32]

LGTM

http://codereview.appspot.com/3217042/diff/18001/test/errchk
File test/errchk (right):

http://codereview.appspot.com/3217042/diff/18001/test/errchk#newcode6
test/errchk:6: # This script checks that the compilers emit the errors which we
expect.
In general please don't reflow comments just because
one or two words change.  In this instance I don't care that much.

[rsc, 2010-12-07 20:28:24]

*** Submitted as ebe1ef6f6b69 ***

errchk: accept multiple source files

R=rsc, iant
CC=golang-dev
http://codereview.appspot.com/3217042

Committer: Russ Cox <rsc@golang.org>