code review 30850044: go.talks/present: fix mouse wheel scrolling direction issue.

go.talks/present: disable mouse wheel scrolling.

[chai2010, 2013-11-25 06:13:14]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go.talks

[adg, 2013-11-25 23:14:17]

Please just delete the mouse wheel handling code entirely. It makes it
impossible to scroll inside output boxes, and leads to a lot of mistaken slide
transitions during presentations. (I have it disabled in my local copy of
present)

[chai2010, 2013-11-28 09:06:44]

On 2013/11/25 23:14:17, adg wrote:
> Please just delete the mouse wheel handling code entirely. It makes it
> impossible to scroll inside output boxes, and leads to a lot of mistaken slide
> transitions during presentations. (I have it disabled in my local copy of
> present)

PTAL

[adg, 2013-11-28 23:09:38]

https://codereview.appspot.com/30850044/diff/50001/present/static/slides.js
File present/static/slides.js (right):

https://codereview.appspot.com/30850044/diff/50001/present/static/slides.js#n...
present/static/slides.js:300: /* Mouse wheel events */
delete this

https://codereview.appspot.com/30850044/diff/50001/present/static/slides.js#n...
present/static/slides.js:303: var tooSoon = false;
delete this

https://codereview.appspot.com/30850044/diff/50001/present/static/slides.js#n...
present/static/slides.js:305: function handleMouseWheel(event) {
delete this

[chai2010, 2013-11-29 00:54:31]

PTAL

https://codereview.appspot.com/30850044/diff/50001/present/static/slides.js
File present/static/slides.js (right):

https://codereview.appspot.com/30850044/diff/50001/present/static/slides.js#n...
present/static/slides.js:300: /* Mouse wheel events */
On 2013/11/28 23:09:38, adg wrote:
> delete this

Done.

https://codereview.appspot.com/30850044/diff/50001/present/static/slides.js#n...
present/static/slides.js:303: var tooSoon = false;
On 2013/11/28 23:09:38, adg wrote:
> delete this

Done.

https://codereview.appspot.com/30850044/diff/50001/present/static/slides.js#n...
present/static/slides.js:305: function handleMouseWheel(event) {
On 2013/11/28 23:09:38, adg wrote:
> delete this

Done.

[adg, 2013-11-29 00:55:47]

LGTM

[adg, 2013-11-29 00:56:29]

*** Submitted as
https://code.google.com/p/go/source/detail?r=c8f1acbf8c2e&repo=talks ***

go.talks/present: disable mouse wheel scrolling.

R=golang-dev, adg
CC=golang-dev
https://codereview.appspot.com/30850044

Committer: Andrew Gerrand <adg@golang.org>