code review 29440043: net: don't return a nested error when happy eyeballs dialing

net: don't return a nested error when happy eyeballs dialing

Also removes an unused variable.

Fixes issue 6795.

[mikio, 2013-11-20 03:08:02]

Hello adg@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2013-11-20 03:11:15]

On 2013/11/20 03:08:02, mikio wrote:
> Hello mailto:adg@golang.org (cc: mailto:golang-dev@googlegroups.com),
> 
> I'd like you to review this change to
> https://code.google.com/p/go

I'm concerned that this is something that could easily break again in the
future. Would you be able to add a test for the return error type ?

[mikio, 2013-11-20 03:11:58]

will leave it to you, adg.

[mikio, 2013-11-20 03:14:34]

On Wed, Nov 20, 2013 at 12:11 PM,  <dave@cheney.net> wrote:

> I'm concerned that this is something that could easily break again in
> the future. Would you be able to add a test for the return error type ?

maybe, but not now. issue 4856 is still open.

[mikio, 2013-12-10 05:31:25]

Hello adg@golang.org, dave@cheney.net (cc: golang-dev@googlegroups.com),

Please take another look.

[mikio, 2013-12-18 12:47:08]

ping

[bradfitz, 2013-12-18 18:21:31]

No test?

[gobot, 2013-12-18 20:30:18]

R=bradfitz@golang.org (assigned by rsc@google.com)

[mikio, 2013-12-19 00:23:55]

On Thu, Dec 19, 2013 at 3:21 AM,  <bradfitz@golang.org> wrote:

> No test?

For now, yes. I have a plan to add a bit comprehensive tests on error
return values once issue 4856 lands.

[bradfitz, 2013-12-19 00:29:29]

LGTM sure.  Hope to see a test later.

[mikio, 2013-12-19 01:00:21]

*** Submitted as https://code.google.com/p/go/source/detail?r=c7958a17fab8 ***

net: don't return a nested error when happy eyeballs dialing

Also removes an unused variable.

Fixes issue 6795.

R=adg, dave, bradfitz, gobot
CC=golang-dev
https://codereview.appspot.com/29440043