Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(675)

Issue 28700043: code review 28700043: doc: update installation instructions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by adg
Modified:
10 years, 5 months ago
Reviewers:
r, dave
CC:
golang-dev, r
Visibility:
Public.

Description

doc: update installation instructions Clarify that GOROOT should only be set when using a custom install path. Remove NetBSD from binary install page (we don't provide binaries). Remove "What's next" links from installation instructions. Emphasize "How to Write Go Code" page. Fixes issue 6613.

Patch Set 1 #

Total comments: 6

Patch Set 2 : diff -r 7698a56314ed https://code.google.com/p/go #

Patch Set 3 : diff -r d2f41f387683 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -102 lines) Patch
M doc/code.html View 2 chunks +25 lines, -1 line 0 comments Download
M doc/install.html View 1 9 chunks +84 lines, -99 lines 0 comments Download
M doc/install-source.html View 1 1 chunk +15 lines, -2 lines 0 comments Download

Messages

Total messages: 6
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 5 months ago (2013-11-19 01:28:21 UTC) #1
r
https://codereview.appspot.com/28700043/diff/1/doc/install-source.html File doc/install-source.html (right): https://codereview.appspot.com/28700043/diff/1/doc/install-source.html#newcode219 doc/install-source.html:219: <i>You're not done yet!</i> this sounds like an admonishment. ...
10 years, 5 months ago (2013-11-20 20:40:41 UTC) #2
adg
PTAL https://codereview.appspot.com/28700043/diff/1/doc/install-source.html File doc/install-source.html (right): https://codereview.appspot.com/28700043/diff/1/doc/install-source.html#newcode219 doc/install-source.html:219: <i>You're not done yet!</i> On 2013/11/20 20:40:41, r ...
10 years, 5 months ago (2013-11-20 20:47:40 UTC) #3
r
LGTM
10 years, 5 months ago (2013-11-20 20:53:03 UTC) #4
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=8b3699321603 *** doc: update installation instructions Clarify that GOROOT should only be ...
10 years, 5 months ago (2013-11-20 20:55:39 UTC) #5
dave_cheney.net
10 years, 5 months ago (2013-11-20 21:13:54 UTC) #6
Wonderful, thanks Andrew and Rob. 

> On 21 Nov 2013, at 7:55, adg@golang.org wrote:
> 
> *** Submitted as
> https://code.google.com/p/go/source/detail?r=8b3699321603 ***
> 
> doc: update installation instructions
> 
> Clarify that GOROOT should only be set when using a custom install path.
> Remove NetBSD from binary install page (we don't provide binaries).
> Remove "What's next" links from installation instructions.
> Emphasize "How to Write Go Code" page.
> 
> Fixes issue 6613.
> 
> R=golang-dev, r
> CC=golang-dev
> https://codereview.appspot.com/28700043
> 
> 
> https://codereview.appspot.com/28700043/
> 
> -- 
> 
> ---You received this message because you are subscribed to the Google Groups
"golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b