Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(880)

Issue 2833041: code review 2833041: netchan: fix locking bug. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by r
Modified:
13 years, 6 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

netchan: fix locking bug. There's no need to hold the client mutex when calling encode, since encode itself uses a mutex to make the writes atomic. However, we need to keep the messages ordered, so add a mutex for that purpose alone. Fixes issue 1244.

Patch Set 1 #

Patch Set 2 : code review 2833041: netchan: fix locking bug. #

Patch Set 3 : code review 2833041: netchan: fix locking bug. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/pkg/netchan/export.go View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 4
r
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.
13 years, 6 months ago (2010-11-02 17:07:11 UTC) #1
r
Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 6 months ago (2010-11-02 17:56:46 UTC) #2
rsc1
LGTM
13 years, 6 months ago (2010-11-02 17:57:47 UTC) #3
r
13 years, 6 months ago (2010-11-02 17:58:30 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=fe5ceed6f98c ***

netchan: fix locking bug.
There's no need to hold the client mutex when calling encode, since encode
itself
uses a mutex to make the writes atomic.  However, we need to keep
the messages ordered, so add a mutex for that purpose alone.
Fixes issue 1244.

R=rsc
CC=golang-dev
http://codereview.appspot.com/2833041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b