Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(399)

Issue 28110043: code review 28110043: [release-branch.go1.2] encoding/gob: do not use Marshal... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by adg
Modified:
10 years, 4 months ago
Reviewers:
CC:
golang-dev
Visibility:
Public.

Description

[release-branch.go1.2] encoding/gob: do not use MarshalText, UnmarshalText ««« CL 22770044 / 23fc3139589c encoding/gob: do not use MarshalText, UnmarshalText This seems to be the best of a long list of bad ways to fix this issue. Fixes issue 6760. R=r CC=golang-dev https://codereview.appspot.com/22770044 »»»

Patch Set 1 #

Patch Set 2 : diff -r 979e3139dceb https://code.google.com/p/go #

Patch Set 3 : diff -r 979e3139dceb https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -11 lines) Patch
M doc/go1.2.html View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/pkg/encoding/gob/doc.go View 1 1 chunk +6 lines, -6 lines 0 comments Download
M src/pkg/encoding/gob/gobencdec_test.go View 1 2 chunks +15 lines, -0 lines 0 comments Download
M src/pkg/encoding/gob/type.go View 1 1 chunk +11 lines, -4 lines 0 comments Download

Messages

Total messages: 2
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
10 years, 4 months ago (2013-11-18 01:39:41 UTC) #1
adg
10 years, 4 months ago (2013-11-18 01:40:12 UTC) #2
*** Submitted as https://code.google.com/p/go/source/detail?r=a30cab4951a3 ***

[release-branch.go1.2] encoding/gob: do not use MarshalText, UnmarshalText

««« CL 22770044 / 23fc3139589c
encoding/gob: do not use MarshalText, UnmarshalText

This seems to be the best of a long list of bad ways to fix this issue.

Fixes issue 6760.

R=r
CC=golang-dev
https://codereview.appspot.com/22770044
»»»

R=golang-dev
CC=golang-dev
https://codereview.appspot.com/28110043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b