Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3496)

Issue 27650045: code review 27650045: cmd/go: test: do not put object files where later steps... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by mwhudson
Modified:
10 years, 2 months ago
Reviewers:
rsc
CC:
golang-codereviews, dfc, gobot, rsc, iant
Visibility:
Public.

Description

cmd/go: test: do not put object files where later steps will find them When recompiling a package whose basename is the name of a standard package for testing with gccgo, a .o file with the basename of the package being tested was being placed in the _test/ directory where the compilation of the test binary then found it when looking for the standard library package. This change puts the object files in a separate directory. Fixes issue 6793

Patch Set 1 #

Patch Set 2 : diff -r d2f41f387683 https://code.google.com/p/go/ #

Patch Set 3 : diff -r d2f41f387683 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/cmd/go/test.go View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11
mwhudson
This will wait until after the 1.2 release I suppose. Are there tests for this ...
10 years, 4 months ago (2013-11-19 20:38:57 UTC) #1
mwhudson
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
10 years, 4 months ago (2013-11-19 20:39:25 UTC) #2
dfc
On 2013/11/19 20:39:25, mwhudson wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...
10 years, 4 months ago (2013-11-19 20:45:53 UTC) #3
dfc
On 2013/11/19 20:39:25, mwhudson wrote: > Hello mailto:golang-dev@googlegroups.com, > > I'd like you to review ...
10 years, 4 months ago (2013-11-19 20:45:54 UTC) #4
mwhudson
On 2013/11/19 20:45:54, dfc wrote: > On 2013/11/19 20:39:25, mwhudson wrote: > > Hello mailto:golang-dev@googlegroups.com, ...
10 years, 4 months ago (2013-11-19 21:10:59 UTC) #5
dfc
Yes, that is an excellent observation. After playing with this CL this afternoon I'm thinking ...
10 years, 4 months ago (2013-11-20 09:00:20 UTC) #6
mwhudson
Ping?
10 years, 3 months ago (2013-12-17 03:12:33 UTC) #7
gobot
Replacing golang-dev with golang-codereviews.
10 years, 3 months ago (2013-12-20 16:26:08 UTC) #8
gobot
R=rsc@golang.org (assigned by dave@cheney.net)
10 years, 2 months ago (2014-01-01 23:06:03 UTC) #9
rsc
LGTM
10 years, 2 months ago (2014-01-07 02:02:48 UTC) #10
rsc
10 years, 2 months ago (2014-01-08 04:53:25 UTC) #11
*** Submitted as https://code.google.com/p/go/source/detail?r=e4e1b9093b90 ***

cmd/go: test: do not put object files where later steps will find them

When recompiling a package whose basename is the name of a standard
package for testing with gccgo, a .o file with the basename of the
package being tested was being placed in the _test/ directory where the
compilation of the test binary then found it when looking for the
standard library package.

This change puts the object files in a separate directory.

Fixes issue 6793

R=golang-codereviews, dave, gobot, rsc, iant
CC=golang-codereviews
https://codereview.appspot.com/27650045

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b