code review 2763041: use copy

use copy

[rsc, 2010-10-27 03:41:44]

Hello gri (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[gri, 2010-10-27 03:50:33]

http://codereview.appspot.com/2763041/diff/2001/src/pkg/crypto/block/cipher.go
File src/pkg/crypto/block/cipher.go (right):

http://codereview.appspot.com/2763041/diff/2001/src/pkg/crypto/block/cipher.g...
src/pkg/crypto/block/cipher.go:54: for i, b := range p {
this should use copy

[gri, 2010-10-27 03:58:40]

LGTM but apply the fix suggested below
- gri

On Tue, Oct 26, 2010 at 8:50 PM, <gri@golang.org> wrote:

>
>
> http://codereview.appspot.com/2763041/diff/2001/src/pkg/crypto/block/cipher.go
> File src/pkg/crypto/block/cipher.go (right):
>
>
>
http://codereview.appspot.com/2763041/diff/2001/src/pkg/crypto/block/cipher.g...
> src/pkg/crypto/block/cipher.go:54: for i, b := range p {
> this should use copy
>
>
> http://codereview.appspot.com/2763041/
>

[rsc, 2010-10-27 04:14:33]

i found a whole bunch more like the one you pointed out.

[rsc, 2010-10-27 04:15:18]

Hello gri (cc: golang-dev@googlegroups.com),

Please take another look.

[gri, 2010-10-27 04:44:38]

LGTM

Nice bug fix in regexp.go.
- gri

On Tue, Oct 26, 2010 at 9:15 PM, <rsc@golang.org> wrote:

> Hello gri (cc: golang-dev@googlegroups.com),
>
> Please take another look.
>
>
>
> http://codereview.appspot.com/2763041/
>

[rsc, 2010-10-27 04:52:59]

*** Submitted as http://code.google.com/p/go/source/detail?r=851194660006 ***

use copy

R=gri
CC=golang-dev
http://codereview.appspot.com/2763041