Issue 2738041: code review 2738041: arm: enable all tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2738041: code review 2738041: arm: enable all tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by rsc

Modified:
14 years, 4 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

arm: enable all tests ARM functionality is now completely working. (Or if it's not, we'll fix it.)

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+169 lines, -1037 lines)			Patch
R	src/all-arm.bash	View		1 chunk	+0 lines, -30 lines	0 comments	Download
M	src/pkg/runtime/arm/asm.s	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	src/pkg/strconv/atof.go	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	src/pkg/strconv/ftoa.go	View		2 chunks	+0 lines, -4 lines	0 comments	Download
M	src/pkg/strconv/internal_test.go	View		1 chunk	+0 lines, -8 lines	0 comments	Download
R	test/arm-pass.txt	View		1 chunk	+0 lines, -487 lines	0 comments	Download
R	test/fail-arm-native.txt	View	1	1 chunk	+0 lines, -11 lines	0 comments	Download
M	test/float_lit.go	View	1	3 chunks	+145 lines, -66 lines	0 comments	Download
R	test/golden-arm.out	View		1 chunk	+0 lines, -131 lines	0 comments	Download
R	test/golden-arm-native.out	View	1	1 chunk	+0 lines, -151 lines	0 comments	Download
M	test/literal.go	View	1	8 chunks	+11 lines, -22 lines	0 comments	Download
M	test/recover2.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/recover3.go	View	1	4 chunks	+7 lines, -9 lines	0 comments	Download
M	test/run	View		1 chunk	+0 lines, -10 lines	0 comments	Download
R	test/run-arm	View		1 chunk	+0 lines, -102 lines	0 comments	Download

Total messages: 3

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 4 months ago (2010-10-26 04:25:10 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=846763eeeea6 *** arm: enable all tests ARM functionality is now completely working. ...

14 years, 4 months ago (2010-10-26 04:25:28 UTC) #2

lgtm