Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3447)

Issue 2661041: code review 2661041: go spec: relaxed syntax for array, slice, and map compo... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by gri
Modified:
13 years, 6 months ago
Reviewers:
CC:
r, rsc, iant, ken2, golang-dev
Visibility:
Public.

Description

go spec: relaxed syntax for array, slice, and map composite literals For elements which are themselves composite literals, the type may be omitted if it is identical to the element type of the containing composite literal.

Patch Set 1 #

Patch Set 2 : code review 2661041: go spec: relaxed syntax for array, slice, and map compo... #

Total comments: 2

Patch Set 3 : code review 2661041: go spec: relaxed syntax for array, slice, and map compo... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M doc/go_spec.html View 3 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 6
gri
Hello r, rsc, iant, ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.
13 years, 6 months ago (2010-10-21 23:35:13 UTC) #1
r
http://codereview.appspot.com/2661041/diff/2001/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/2661041/diff/2001/doc/go_spec.html#newcode1983 doc/go_spec.html:1983: Value = Expression | LiteralValue . if the Value ...
13 years, 6 months ago (2010-10-21 23:48:09 UTC) #2
iant
LGTM
13 years, 6 months ago (2010-10-22 00:08:25 UTC) #3
rsc1
LGTM
13 years, 6 months ago (2010-10-22 02:31:44 UTC) #4
gri
http://codereview.appspot.com/2661041/diff/2001/doc/go_spec.html File doc/go_spec.html (right): http://codereview.appspot.com/2661041/diff/2001/doc/go_spec.html#newcode1983 doc/go_spec.html:1983: Value = Expression | LiteralValue . On 2010/10/21 23:48:09, ...
13 years, 6 months ago (2010-10-22 15:58:28 UTC) #5
gri
13 years, 6 months ago (2010-10-22 15:58:58 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=8673c390f992 ***

go spec: relaxed syntax for array, slice, and map composite literals

For elements which are themselves composite literals, the type may
be omitted if it is identical to the element type of the containing
composite literal.

R=r, rsc, iant, ken2
CC=golang-dev
http://codereview.appspot.com/2661041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b