Issue 2660042: code review 2660042: gobs: error cleanup part 1.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2660042: code review 2660042: gobs: error cleanup part 1. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by r

Modified:
14 years, 4 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

gobs: error cleanup part 1. Remove err from the encoderState and decoderState types, so we're not always copying to and from various copies of the error, and then use panic/recover to eliminate lots of error checking. another pass might take a crack at the same thing for the compilation phase.

Patch Set 1 #

Patch Set 2 : code review 2660042: gobs: error cleanup part 1. #

Patch Set 3 : code review 2660042: gobs: error cleanup part 1. #

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+229 lines, -214 lines)			Patch
M	src/pkg/gob/Makefile	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/gob/codec_test.go	View		4 chunks	+12 lines, -18 lines	0 comments	Download
M	src/pkg/gob/decode.go	View	1 2	29 chunks	+78 lines, -96 lines	0 comments	Download
M	src/pkg/gob/decoder.go	View	1 2	9 chunks	+22 lines, -18 lines	0 comments	Download
M	src/pkg/gob/encode.go	View		12 chunks	+34 lines, -42 lines	0 comments	Download
M	src/pkg/gob/encoder.go	View		6 chunks	+11 lines, -10 lines	0 comments	Download
M	src/pkg/gob/encoder_test.go	View		6 chunks	+30 lines, -30 lines	0 comments	Download
A	src/pkg/gob/error.go	View	2	1 chunk	+41 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 4 months ago (2010-10-22 20:58:15 UTC) #1

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 4 months ago (2010-10-22 21:07:16 UTC) #3

14 years, 4 months ago (2010-10-22 22:16:39 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=7059c89a2346 ***

gobs: error cleanup part 1.
Remove err from the encoderState and decoderState types, so we're
not always copying to and from various copies of the error, and then
use panic/recover to eliminate lots of error checking.

another pass might take a crack at the same thing for the compilation phase.

R=rsc
CC=golang-dev
http://codereview.appspot.com/2660042

Expand All Messages | Collapse All Messages