Issue 2652042: code review 2652042: gob: error cleanup 2

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2652042: code review 2652042: gob: error cleanup 2 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by r

Modified:
14 years, 4 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

gob: error cleanup 2 Simplify error handling during the compilation phase.

Patch Set 1 #

Patch Set 2 : code review 2652042: gob: error cleanup 2 #

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -123 lines)			Patch
	M	src/pkg/gob/decode.go	View		18 chunks	+25 lines, -63 lines	0 comments	Download
	M	src/pkg/gob/encode.go	View		10 chunks	+39 lines, -60 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 4 months ago (2010-10-22 23:01:08 UTC) #1

14 years, 4 months ago (2010-10-22 23:07:31 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=fe1adc73614b ***

gob: error cleanup 2
Simplify error handling during the compilation phase.

R=rsc
CC=golang-dev
http://codereview.appspot.com/2652042

Expand All Messages | Collapse All Messages