code review 2629041: release.2010-10-20

release.2010-10-20

[adg, 2010-10-21 00:03:24]

Hello r, rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[r, 2010-10-21 00:08:10]

http://codereview.appspot.com/2629041/diff/1/doc/devel/release.html
File doc/devel/release.html (right):

http://codereview.appspot.com/2629041/diff/1/doc/devel/release.html#newcode23
doc/devel/release.html:23: * arm: code generation fixes.
except for FP, most tests now pass

http://codereview.appspot.com/2629041/diff/1/doc/devel/release.html#newcode28
doc/devel/release.html:28: * gob: handle interface values by a method analogous
to the way it handles maps.
?? gob hasn't changed.
i think this is about a minor change to reflect, not worth reporting.
the gob change isn't in yet.

http://codereview.appspot.com/2629041/diff/1/doc/devel/release.html#newcode32
doc/devel/release.html:32: * nntp: remove nntp package from the standard
library.
say where it is

http://codereview.appspot.com/2629041/diff/1/doc/devel/release.html#newcode34
doc/devel/release.html:34: * reflect: add InterfaceValue.Get to enable setting
of an interface.
drop this. it's too damn subtle.

http://codereview.appspot.com/2629041/diff/1/doc/devel/release.html#newcode36
doc/devel/release.html:36: update arm softfloat - no more R12.
drop

[adg, 2010-10-21 00:24:38]

http://codereview.appspot.com/2629041/diff/1/doc/devel/release.html
File doc/devel/release.html (right):

http://codereview.appspot.com/2629041/diff/1/doc/devel/release.html#newcode23
doc/devel/release.html:23: * arm: code generation fixes.
On 2010/10/21 00:08:11, r wrote:
> except for FP, most tests now pass

Done.

http://codereview.appspot.com/2629041/diff/1/doc/devel/release.html#newcode28
doc/devel/release.html:28: * gob: handle interface values by a method analogous
to the way it handles maps.
On 2010/10/21 00:08:11, r wrote:
> ?? gob hasn't changed.
> i think this is about a minor change to reflect, not worth reporting.
> the gob change isn't in yet.

Done. My mistake. Somehow part of the reflect change's description snuck in.

http://codereview.appspot.com/2629041/diff/1/doc/devel/release.html#newcode32
doc/devel/release.html:32: * nntp: remove nntp package from the standard
library.
On 2010/10/21 00:08:11, r wrote:
> say where it is

Done.

http://codereview.appspot.com/2629041/diff/1/doc/devel/release.html#newcode34
doc/devel/release.html:34: * reflect: add InterfaceValue.Get to enable setting
of an interface.
On 2010/10/21 00:08:11, r wrote:
> drop this. it's too damn subtle.

Done.

http://codereview.appspot.com/2629041/diff/1/doc/devel/release.html#newcode36
doc/devel/release.html:36: update arm softfloat - no more R12.
On 2010/10/21 00:08:11, r wrote:
> drop

Done.

[r, 2010-10-21 00:29:07]

LGTM

[adg, 2010-10-21 00:33:48]

*** Submitted as http://code.google.com/p/go/source/detail?r=79997f0e5823 ***

release.2010-10-20

R=r, rsc
CC=golang-dev
http://codereview.appspot.com/2629041