Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(87)

Issue 2623043: code review 2623043: 5l, 6l, 8l: introduce sub-symbols (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 4 months ago by rsc
Modified:
14 years, 4 months ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

5l, 6l, 8l: introduce sub-symbols Sub-symbols are laid out inside a larger symbol but can be addressed directly. Use to make Mach-O pointer array not a special case. Will use later to describe ELF sections. Glimpses of the beginning of ELF loading.

Patch Set 1 #

Patch Set 2 : code review 2623043: 5l, 6l, 8l: introduce sub-symbols #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -48 lines) Patch
M src/cmd/5l/l.h View 4 chunks +3 lines, -9 lines 0 comments Download
M src/cmd/6l/l.h View 3 chunks +3 lines, -2 lines 0 comments Download
M src/cmd/6l/span.c View 3 chunks +8 lines, -9 lines 0 comments Download
M src/cmd/8l/l.h View 3 chunks +5 lines, -3 lines 0 comments Download
M src/cmd/8l/span.c View 1 chunk +3 lines, -9 lines 0 comments Download
M src/cmd/ld/data.c View 5 chunks +21 lines, -5 lines 0 comments Download
M src/cmd/ld/macho.c View 8 chunks +24 lines, -11 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 4 months ago (2010-10-22 19:27:48 UTC) #1
rsc
*** Submitted as 97223beab61b *** 5l, 6l, 8l: introduce sub-symbols Sub-symbols are laid out inside ...
14 years, 4 months ago (2010-10-22 19:27:53 UTC) #2
ken3
14 years, 4 months ago (2010-10-22 20:22:46 UTC) #3
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b