Issue 2620041: code review 2620041: 5l: two stack split bugs in one day

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2620041: code review 2620041: 5l: two stack split bugs in one day (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by rsc

Modified:
14 years, 5 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

5l: two stack split bugs in one day An ARM expert could probably phrase the comparison in fewer instructions, but this works.

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -9 lines)			Patch
	M	src/cmd/5l/noop.c	View	1	3 chunks	+27 lines, -9 lines	0 comments	Download

Total messages: 3

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 5 months ago (2010-10-20 22:11:05 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=ea9337f56de2 *** 5l: two stack split bugs in one day An ARM ...

14 years, 5 months ago (2010-10-20 22:12:00 UTC) #2

lgtm