Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(98)

Issue 26170043: code review 26170043: doc/asm: more about SP, ARM R11 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by rsc
Modified:
10 years, 4 months ago
Reviewers:
r, minux1
CC:
golang-dev, minux1, r
Visibility:
Public.

Description

doc/asm: more about SP, ARM R11 Also rename URL to /doc/asm.

Patch Set 1 #

Patch Set 2 : diff -r 2a5e92c6efc9 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 2a5e92c6efc9 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 2a5e92c6efc9 https://code.google.com/p/go/ #

Total comments: 3

Patch Set 5 : diff -r 23fc3139589c https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -12 lines) Patch
M doc/asm.html View 1 2 3 4 4 chunks +45 lines, -8 lines 0 comments Download
M src/cmd/5a/doc.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/6a/doc.go View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/cmd/8a/doc.go View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
10 years, 4 months ago (2013-11-13 18:20:16 UTC) #1
minux1
LGTM. Thank you, it also corrected one of my misunderstandings. Do you also want to ...
10 years, 4 months ago (2013-11-13 18:34:46 UTC) #2
r
LGTM https://codereview.appspot.com/26170043/diff/60001/doc/asm.html File doc/asm.html (right): https://codereview.appspot.com/26170043/diff/60001/doc/asm.html#newcode116 doc/asm.html:116: The <code>FP</code> pseudo-register is a virtual frame pointer. ...
10 years, 4 months ago (2013-11-13 21:40:33 UTC) #3
rsc
10 years, 4 months ago (2013-11-14 02:29:39 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=b1edf8faa5d6 ***

doc/asm: more about SP, ARM R11

Also rename URL to /doc/asm.

R=golang-dev, minux.ma, r
CC=golang-dev
https://codereview.appspot.com/26170043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b