Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(259)

Issue 261041: code review 261041: fix bug in complex printing: imaginary didn't have same... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years ago by r
Modified:
15 years ago
Reviewers:
CC:
rsc, ken2, ken3, golang-dev
Visibility:
Public.

Description

fix bug in complex printing: imaginary didn't have same format as real. add tests.

Patch Set 1 #

Patch Set 2 : code review 261041: fix bug in complex printing: imaginary didn't have same... #

Patch Set 3 : code review 261041: fix bug in complex printing: imaginary didn't have same... #

Patch Set 4 : code review 261041: fix bug in complex printing: imaginary didn't have same... #

Patch Set 5 : code review 261041: fix bug in complex printing: imaginary didn't have same... #

Patch Set 6 : code review 261041: fix bug in complex printing: imaginary didn't have same... #

Patch Set 7 : code review 261041: fix bug in complex printing: imaginary didn't have same... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -10 lines) Patch
M src/pkg/fmt/fmt_test.go View 1 2 3 4 5 6 2 chunks +29 lines, -0 lines 0 comments Download
M src/pkg/fmt/format.go View 1 7 chunks +18 lines, -9 lines 0 comments Download
M src/pkg/fmt/print.go View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6
r
Hello rsc, ken (cc: golang-dev@googlegroups.com), I'd like you to review this change.
15 years ago (2010-03-06 21:00:18 UTC) #1
r
fix reviewer
15 years ago (2010-03-06 21:05:44 UTC) #2
ken3
i didnt include any print tests because 8g cant execute it yet and you will ...
15 years ago (2010-03-06 21:10:02 UTC) #3
ken3
LGTM
15 years ago (2010-03-06 21:12:45 UTC) #4
r2
OK. I'll comment out the tests for now, but the fixes are still valuable. -rob ...
15 years ago (2010-03-06 21:36:59 UTC) #5
r
15 years ago (2010-03-06 21:38:18 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=fb0fe383d0ff ***

fix bug in complex printing: imaginary didn't have same format as real.
add tests.

R=rsc, ken2, ken3
CC=golang-dev
http://codereview.appspot.com/261041
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b