Issue 2585043: code review 2585043: goinstall: fix documentation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2585043: code review 2585043: goinstall: fix documentation (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by fhs

Modified:
14 years, 4 months ago

Reviewers:

CC:
golang-dev, adg

Visibility:
Public.

Description

goinstall: fix documentation $ goinstall github.com/hoisie/web.go.git goinstall: github.com/hoisie/web.go.git: repository github.com/hoisie/web.go.git should not have .git suffix

Patch Set 2 : code review 2585043: goinstall: fix documentation #

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/cmd/goinstall/doc.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fhs

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 4 months ago (2010-10-20 18:45:24 UTC) #1

adg

*** Submitted as http://code.google.com/p/go/source/detail?r=6053abaa495b *** goinstall: fix documentation typo R=golang-dev, adg CC=golang-dev http://codereview.appspot.com/2585043 Committer: Andrew ...

14 years, 4 months ago (2010-10-20 23:47:06 UTC) #2

adg

14 years, 4 months ago (2010-10-20 23:47:12 UTC) #3

LGTM

On 21 October 2010 05:45,  <fshahriar@gmail.com> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> goinstall: fix documentation
>
> $ goinstall github.com/hoisie/web.go.git
> goinstall: github.com/hoisie/web.go.git: repository
> github.com/hoisie/web.go.git should not have .git suffix
>
> Please review this at http://codereview.appspot.com/2585043/
>
> Affected files:
>  M src/cmd/goinstall/doc.go
>
>
> Index: src/cmd/goinstall/doc.go
> ===================================================================
> --- a/src/cmd/goinstall/doc.go
> +++ b/src/cmd/goinstall/doc.go
> @@ -50,8 +50,8 @@
>
>        GitHub (Git)
>
> -               import "github.com/user/project.git"
> -               import "github.com/user/project.git/sub/directory"
> +               import "github.com/user/project"
> +               import "github.com/user/project/sub/directory"
>
>        Google Code Project Hosting (Mercurial, Subversion)
>
>
>
>

Expand All Messages | Collapse All Messages