Issue 25750043: code review 25750043: [release-branch.go1.2] misc/emacs: various cleanups

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 25750043: code review 25750043: [release-branch.go1.2] misc/emacs: various cleanups (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by adg

Modified:
10 years, 5 months ago

Reviewers:

CC:
golang-dev

Visibility:
Public.

Description

[release-branch.go1.2] misc/emacs: various cleanups ««« CL 20100043 / 9fe43a708b89 misc/emacs: various cleanups - Use #' for function symbols - Remove unused variables - Use declare-function to shut up byte compiler This is identical to CL 19010044 with one exception: Making sure it doesn't break on Emacs 22.1 R=adonovan, bradfitz, shendaras CC=golang-dev https://codereview.appspot.com/20100043 Committer: Alan Donovan <adonovan@google.com> »»»

Patch Set 1 #

Patch Set 2 : diff -r 16e33df3c2e8 https://code.google.com/p/go #

Patch Set 3 : diff -r 16e33df3c2e8 https://code.google.com/p/go #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -24 lines)			Patch
	M	misc/emacs/go-mode.el	View	1	11 chunks	+27 lines, -24 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 5 months ago (2013-11-13 03:34:56 UTC) #1

adg

10 years, 5 months ago (2013-11-13 03:35:22 UTC) #2

*** Submitted as https://code.google.com/p/go/source/detail?r=b1563f333fac ***

[release-branch.go1.2] misc/emacs: various cleanups

««« CL 20100043 / 9fe43a708b89
misc/emacs: various cleanups

- Use #' for function symbols
- Remove unused variables
- Use declare-function to shut up byte compiler

This is identical to CL 19010044 with one exception: Making sure
it doesn't break on Emacs 22.1

R=adonovan, bradfitz, shendaras
CC=golang-dev
https://codereview.appspot.com/20100043

Committer: Alan Donovan <adonovan@google.com>
»»»

R=golang-dev
CC=golang-dev
https://codereview.appspot.com/25750043

Expand All Messages | Collapse All Messages