Issue 257042: code review 257042: 6g complex type usable

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 257042: code review 257042: 6g complex type usable (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by ken3

Modified:
15 years ago

Reviewers:
r

CC:
rsc, golang-dev

Visibility:
Public.

Description

6g complex type usable 8g and 5g have stubs to ignore complex

Patch Set 1 #

Patch Set 2 : code review 257042: 6g complex type usable #

Total comments: 2

Created: 15 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+590 lines, -142 lines)			Patch
M	src/cmd/5g/cgen.c	View		3 chunks	+18 lines, -0 lines	0 comments	Download
M	src/cmd/6g/cgen.c	View		3 chunks	+36 lines, -27 lines	0 comments	Download
M	src/cmd/6g/cplx.c	View		6 chunks	+130 lines, -46 lines	0 comments	Download
M	src/cmd/6g/gg.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/cmd/8g/cgen.c	View		3 chunks	+18 lines, -0 lines	0 comments	Download
M	src/cmd/gc/go.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/cmd/gc/lex.c	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	src/cmd/gc/subr.c	View		4 chunks	+18 lines, -0 lines	0 comments	Download
M	src/cmd/gc/typecheck.c	View		6 chunks	+92 lines, -1 line	0 comments	Download
M	src/cmd/gc/walk.c	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	src/pkg/fmt/print.go	View		8 chunks	+120 lines, -0 lines	2 comments	Download
M	src/pkg/reflect/type.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/reflect/value.go	View		2 chunks	+62 lines, -62 lines	0 comments	Download
M	src/pkg/runtime/print.c	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
M	test/ken/cplx0.go	View		1 chunk	+1 line, -3 lines	0 comments	Download
A	test/ken/cplx3.go	View		1 chunk	+42 lines, -0 lines	0 comments	Download
A	test/ken/cplx4.go	View		1 chunk	+40 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ken3

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years ago (2010-03-06 04:16:02 UTC) #1

ken3

*** Submitted as http://code.google.com/p/go/source/detail?r=e65a9a24dc4b *** 6g complex type usable 8g and 5g have stubs to ...

15 years ago (2010-03-06 04:16:06 UTC) #2

15 years ago (2010-03-06 06:35:50 UTC) #3

http://codereview.appspot.com/257042/diff/2001/3011
File src/pkg/fmt/print.go (right):

http://codereview.appspot.com/257042/diff/2001/3011#newcode561
src/pkg/fmt/print.go:561: //	case complex64:
you need code here to handle %v.
also there need to be tests.

http://codereview.appspot.com/257042/diff/2001/3011#newcode928
src/pkg/fmt/print.go:928: p.fmt.fmt_e32(real(v))
there's a lot of annoying repetition here. it might be avoidable using a table
with method pointers.

Expand All Messages | Collapse All Messages