Issue 25640044: code review 25640044: [release-branch.go1.2] net/textproto: fix CanonicalMIME...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 25640044: code review 25640044: [release-branch.go1.2] net/textproto: fix CanonicalMIME... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by adg

Modified:
10 years, 5 months ago

Reviewers:

CC:
golang-dev

Visibility:
Public.

Description

[release-branch.go1.2] net/textproto: fix CanonicalMIMEHeaderKey panic ««« CL 21450043 / e081962da65c net/textproto: fix CanonicalMIMEHeaderKey panic Fixes issue 6712 R=golang-dev, adg, rsc CC=golang-dev https://codereview.appspot.com/21450043 »»»

Patch Set 1 #

Patch Set 2 : diff -r c191dec77664 https://code.google.com/p/go #

Patch Set 3 : diff -r c191dec77664 https://code.google.com/p/go #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
	M	src/pkg/net/textproto/reader.go	View	1	1 chunk	+3 lines, -6 lines	0 comments	Download
	M	src/pkg/net/textproto/reader_test.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 5 months ago (2013-11-13 03:29:18 UTC) #1

adg

10 years, 5 months ago (2013-11-13 03:29:44 UTC) #2

*** Submitted as https://code.google.com/p/go/source/detail?r=d6a5c861f4e2 ***

[release-branch.go1.2] net/textproto: fix CanonicalMIMEHeaderKey panic

««« CL 21450043 / e081962da65c
net/textproto: fix CanonicalMIMEHeaderKey panic

Fixes issue 6712

R=golang-dev, adg, rsc
CC=golang-dev
https://codereview.appspot.com/21450043
»»»

R=golang-dev
CC=golang-dev
https://codereview.appspot.com/25640044

Expand All Messages | Collapse All Messages