Issue 2414041: code review 2414041: crypto/tls: make SetReadTimeout work.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2414041: code review 2414041: crypto/tls: make SetReadTimeout work. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by agl

Modified:
13 years, 6 months ago

Reviewers:

CC:
rsc, agl1, cw, r2, golang-dev

Visibility:
Public.

Description

crypto/tls: make SetReadTimeout work. Fixes issue 1181.

Patch Set 1 #

Patch Set 2 : code review 2414041: crypto/tls: make SetReadTimeout work. #

Patch Set 3 : code review 2414041: crypto/tls: make SetReadTimeout work. #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	src/pkg/crypto/tls/conn.go	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

doesn't seem to work for me, test with: setting timeout low truncating header sent to ...

13 years, 6 months ago (2010-10-10 05:02:09 UTC) #2

LGTM On Oct 9, 2010, at 11:17 AM, agl@golang.org wrote: > http://codereview.appspot.com/2414041/

13 years, 6 months ago (2010-10-10 21:57:23 UTC) #4

agl

Hello rsc, agl1, cw, r2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

13 years, 6 months ago (2010-10-11 14:40:42 UTC) #6

agl

13 years, 6 months ago (2010-10-11 14:41:25 UTC) #7

*** Submitted as http://code.google.com/p/go/source/detail?r=659c1c46e665 ***

	crypto/tls: make SetReadTimeout work.

        Fixes issue 1181.

R=rsc, agl1, cw, r2
CC=golang-dev
http://codereview.appspot.com/2414041

Expand All Messages | Collapse All Messages