Issue 2400041: code review 2400041: bug in stack size in arm.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2400041: code review 2400041: bug in stack size in arm. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by ken3

Modified:
14 years, 5 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

bug in stack size in arm. stack is off by one if calling through reflect.Call

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -14 lines)			Patch
M	src/pkg/runtime/arm/asm.s	View	4 chunks	+13 lines, -11 lines	0 comments	Download
M	src/pkg/runtime/proc.c	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/runtime.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3

ken3

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 5 months ago (2010-10-08 23:46:03 UTC) #1

ken3

*** Submitted as http://code.google.com/p/go/source/detail?r=8c52477401ad *** bug in stack size in arm. stack is off by ...

14 years, 5 months ago (2010-10-08 23:46:11 UTC) #2

rsc

14 years, 5 months ago (2010-10-11 01:02:24 UTC) #3

LGTM

> +void   gogocall(Gobuf*, void(*)(void), int64);

should probably be int32.
the arm code at least only looks at the bottom 32 bits