Issue 23680043: code review 23680043: emacs: allow users to customize the gofmt command, in p...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 23680043: code review 23680043: emacs: allow users to customize the gofmt command, in p... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by Sameer Ajmani

Modified:
10 years, 5 months ago

Reviewers:
iant, adonovan

CC:
adonovan, golang-dev

Visibility:
Public.

Description

emacs: allow users to customize the gofmt command, in particular, to use goimports instead.

Patch Set 2 : diff -r e6794866ebeb https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r e6794866ebeb https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r e6794866ebeb https://go.googlecode.com/hg/ #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	misc/emacs/go-mode.el	View	1	2 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Sameer Ajmani

Hello adonovan (cc: golang-dev, golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 5 months ago (2013-11-08 16:17:29 UTC) #1

adonovan

LGTM https://codereview.appspot.com/23680043/diff/1/misc/emacs/go-mode.el File misc/emacs/go-mode.el (right): https://codereview.appspot.com/23680043/diff/1/misc/emacs/go-mode.el#newcode161 misc/emacs/go-mode.el:161: "The 'gofmt' command. Some users may replace this ...

10 years, 5 months ago (2013-11-08 16:24:31 UTC) #2

Sameer Ajmani

On 2013/11/08 16:24:31, adonovan wrote: > LGTM > > https://codereview.appspot.com/23680043/diff/1/misc/emacs/go-mode.el > File misc/emacs/go-mode.el (right): > ...

10 years, 5 months ago (2013-11-08 16:27:32 UTC) #3

Sameer Ajmani

*** Submitted as https://code.google.com/p/go/source/detail?r=341a490e4736 *** emacs: allow users to customize the gofmt command, in particular, ...

10 years, 5 months ago (2013-11-08 16:31:55 UTC) #4

iant

10 years, 5 months ago (2013-11-08 17:17:26 UTC) #5

Message was sent while issue was closed.

The tree is frozen right now, pending the 1.2 release.  Please hold off on
submitting changes.

This one is in so I guess we can let it ride, but please don't do any more. 
Thanks.

Expand All Messages | Collapse All Messages