code review 2309043: Add SOCK_SEQPACKET support to Unix socket.

Add SOCK_SEQPACKET support to Unix socket.

[albert.strasheim, 2010-10-01 13:58:09]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2010-10-01 21:02:03]

thanks.

seqpacket is definitely not the right name.
unixpacket maybe.  grep for "unix" in the
package directory.  there are other places
that need changes too.

russ

[albert.strasheim, 2010-10-04 07:24:05]

Hello golang-dev@googlegroups.com, rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[albert.strasheim, 2010-10-04 07:27:13]

Hello

I changed more files to add tests, etc., but I'm not sure how to add them to
this issue.

The guide talks about "hg change", which seems to make a new issue, and about
"hg mail", but this only seems to send mail about files that were changed at the
time I created the issue.

How do I add more changed files to an issue?

Regards

Albert

[rsc, 2010-10-04 10:31:29]

> The guide talks about "hg change", which seems to make a new issue, and
> about "hg mail", but this only seems to send mail about files that were
> changed at the time I created the issue.
>
> How do I add more changed files to an issue?

hg change 2309043
add to Files: list in editor

or

hg file 2309043 filename...

russ

[albert.strasheim, 2010-10-04 10:50:13]

Hello golang-dev@googlegroups.com, rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[albert.strasheim, 2010-10-04 10:51:00]

Hello

> hg change 2309043
> add to Files: list in editor

Tried this, but it seemed to ignore the files I added.

> or
> hg file 2309043 filename...

This worked. Thanks.

Regards,

Albert

[albert.strasheim, 2010-10-04 10:52:55]

http://codereview.appspot.com/2309043/diff/15001/src/pkg/net/unixsock.go
File src/pkg/net/unixsock.go (right):

http://codereview.appspot.com/2309043/diff/15001/src/pkg/net/unixsock.go#newc...
src/pkg/net/unixsock.go:91: func (a *UnixAddr) Network() string {
Not quite sure what to do here.

Should UnixAddr get a Seqpacket bool?

[rsc, 2010-10-12 13:55:48]

On Mon, Oct 4, 2010 at 06:52,  <fullung@gmail.com> wrote:
>
> http://codereview.appspot.com/2309043/diff/15001/src/pkg/net/unixsock.go
> File src/pkg/net/unixsock.go (right):
>
>
http://codereview.appspot.com/2309043/diff/15001/src/pkg/net/unixsock.go#newc...
> src/pkg/net/unixsock.go:91: func (a *UnixAddr) Network() string {
> Not quite sure what to do here.
>
> Should UnixAddr get a Seqpacket bool?

Maybe it should just be Net string
(replacing Datagram bool)
and it can be "unix", "unixgram", or "unixpacket".
Unless there is unixpacketgram.

Russ

[albert.strasheim, 2010-10-12 14:19:47]

Hello

> Maybe it should just be Net string
> (replacing Datagram bool)
> and it can be "unix", "unixgram", or "unixpacket".
> Unless there is unixpacketgram.

unixpacket is both connection-oriented and datagram-y.

I'll make the changes. Thanks very much for the review.

Cheers

Albert

[rsc1, 2010-11-01 18:55:19]

On 2010/10/12 14:19:47, albert.strasheim wrote:
> Hello
> 
> > Maybe it should just be Net string
> > (replacing Datagram bool)
> > and it can be "unix", "unixgram", or "unixpacket".
> > Unless there is unixpacketgram.
> 
> unixpacket is both connection-oriented and datagram-y.
> 
> I'll make the changes. Thanks very much for the review.

I don't see the changes yet.

[albert.strasheim, 2010-11-02 07:48:34]

Hello

On 2010/11/01 18:55:19, rsc1 wrote:
> On 2010/10/12 14:19:47, albert.strasheim wrote:
> > Hello
> > 
> > > Maybe it should just be Net string
> > > (replacing Datagram bool)
> > > and it can be "unix", "unixgram", or "unixpacket".
> > > Unless there is unixpacketgram.
> > 
> > unixpacket is both connection-oriented and datagram-y.
> > 
> > I'll make the changes. Thanks very much for the review.
> 
> I don't see the changes yet.

I'm going to finish up 2331044 before I get back to this. There's some
overlapping code.

Regards

Albert

[albert.strasheim, 2010-12-08 06:04:16]

Hello golang-dev@googlegroups.com, rsc, rsc1 (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-01-19 19:22:01]

*** Submitted as 12da6b6cdfd6 ***

net: add unixpacket

R=golang-dev, rsc, rsc1
CC=golang-dev
http://codereview.appspot.com/2309043

Committer: Russ Cox <rsc@golang.org>