Issue 2303041: code review 2303041: http: fix http handler signature changes previously missed

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2303041: code review 2303041: http: fix http handler signature changes previously missed (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by stephenm

Modified:
13 years, 7 months ago

Reviewers:

CC:
adg, rsc, golang-dev

Visibility:
Public.

Description

http: fix http handler signature changes previously missed

Patch Set 1 #

Patch Set 2 : code review 2303041: http: fix http handler signature changes previously missed #

Patch Set 3 : code review 2303041: http: fix http handler signature changes previously missed #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -26 lines)			Patch
	M	src/pkg/http/server.go	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/pkg/http/triv.go	View		4 chunks	+25 lines, -25 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

stephenm

Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change.

13 years, 7 months ago (2010-09-29 08:46:34 UTC) #1

adg

LGTM On 29 September 2010 18:46, <stephenm@golang.org> wrote: > Reviewers: adg, > > Message: > ...

13 years, 7 months ago (2010-09-29 23:34:46 UTC) #3

stephenm

13 years, 7 months ago (2010-09-30 03:22:56 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=e3e83b181d3c ***

http: fix http handler signature changes previously missed

R=adg, rsc
CC=golang-dev
http://codereview.appspot.com/2303041

Expand All Messages | Collapse All Messages