code review 229045: net: put [ ] around IPv6 addresses for Dial

net: put [ ] around IPv6 addresses for Dial

Update issue 538.

[rsc, 2010-03-04 00:51:22]

Hello r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[r2, 2010-03-04 01:27:25]

LGTM

On Mar 3, 2010, at 4:51 PM, rsc@golang.org wrote:

> Reviewers: r,
>
> Message:
> Hello r (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change.
>
>
> Description:
> net: put [ ] around IPv6 addresses for Dial
>
> Update issue 538.
>
> Please review this at http://codereview.appspot.com/229045/show
>
> Affected files:
>  M src/pkg/net/dnsconfig.go
>
>
> Index: src/pkg/net/dnsconfig.go
> ===================================================================
> --- a/src/pkg/net/dnsconfig.go
> +++ b/src/pkg/net/dnsconfig.go
> @@ -49,7 +49,11 @@
> 				// just an IP address.  Otherwise we need DNS
> 				// to look it up.
> 				name := f[1]
> -				if len(ParseIP(name)) != 0 {
> +				switch len(ParseIP(name)) {
> +				case 16:
> +					name = "[" + name + "]"
> +					fallthrough
> +				case 4:
> 					a = a[0 : n+1]
> 					a[n] = name
> 					conf.servers = a
>
>

[rsc, 2010-03-04 01:30:41]

*** Submitted as http://code.google.com/p/go/source/detail?r=395d65ad09ac ***

net: put [ ] around IPv6 addresses for Dial

Update issue 538.

R=r
CC=golang-dev
http://codereview.appspot.com/229045