Issue 22770044: code review 22770044: encoding/gob: do not use MarshalText, UnmarshalText

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 22770044: code review 22770044: encoding/gob: do not use MarshalText, UnmarshalText (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by rsc

Modified:
10 years, 5 months ago

Reviewers:
r

CC:
r, golang-dev

Visibility:
Public.

Description

encoding/gob: do not use MarshalText, UnmarshalText This seems to be the best of a long list of bad ways to fix this issue. Fixes issue 6760.

Patch Set 1 #

Patch Set 2 : diff -r 2a5e92c6efc9 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 2a5e92c6efc9 https://code.google.com/p/go/ #

Patch Set 4 : diff -r d76ade89413f https://code.google.com/p/go/ #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -11 lines)			Patch
M	doc/go1.2.html	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/pkg/encoding/gob/doc.go	View	1	1 chunk	+6 lines, -6 lines	0 comments	Download
M	src/pkg/encoding/gob/gobencdec_test.go	View	1 2	2 chunks	+15 lines, -0 lines	0 comments	Download
M	src/pkg/encoding/gob/type.go	View	1 2	1 chunk	+11 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

10 years, 5 months ago (2013-11-13 20:36:45 UTC) #1

rsc

10 years, 5 months ago (2013-11-14 02:29:24 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=23fc3139589c ***

encoding/gob: do not use MarshalText, UnmarshalText

This seems to be the best of a long list of bad ways to fix this issue.

Fixes issue 6760.

R=r
CC=golang-dev
https://codereview.appspot.com/22770044

Expand All Messages | Collapse All Messages