Issue 224051: code review 224051: %q in fmt: if the object is a Stringer, use String() to...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 224051: code review 224051: %q in fmt: if the object is a Stringer, use String() to... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by r

Modified:
15 years, 1 month ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

%q in fmt: if the object is a Stringer, use String() to get the value to quote.

Patch Set 1 #

Patch Set 2 : code review 224051: %q in fmt: if the object is a Stringer, use String() to... #

Patch Set 3 : code review 224051: %q in fmt: if the object is a Stringer, use String() to... #

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -1 line)			Patch
M	src/pkg/fmt/fmt_test.go	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/pkg/fmt/print.go	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/pkg/fmt/stringer_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change.

15 years, 1 month ago (2010-02-25 06:20:22 UTC) #1

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

15 years, 1 month ago (2010-02-25 06:21:14 UTC) #3

15 years, 1 month ago (2010-02-25 06:29:43 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=673d7af797fb ***

%q in fmt: if the object is a Stringer, use String() to get the value to quote.

R=rsc
CC=golang-dev
http://codereview.appspot.com/224051

Expand All Messages | Collapse All Messages