code review 224042: Add complex/complex64/complex128 to Vim syntax file.

Add new complex types, functions and literals to Vim syntax file.

[dsymonds, 2010-02-24 23:10:02]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2010-02-24 23:12:54]

please sit on this for a while.
once they've been discussed and are in the language spec,
then it will be time to update the other things.
right now complex is still an experiment in 6g.
(it's one that is likely to succeed, but let's
let it run its course.)  updating the vim syntax
now just means having to update it again later
if other predeclared identifiers are added.

russ

[dsymonds, 2010-02-24 23:13:49]

Aah, okay. That's fine. I thought the matter had been settled.

On Thu, Feb 25, 2010 at 10:12 AM, Russ Cox <rsc@golang.org> wrote:
> please sit on this for a while.
> once they've been discussed and are in the language spec,
> then it will be time to update the other things.
> right now complex is still an experiment in 6g.
> (it's one that is likely to succeed, but let's
> let it run its course.)  updating the vim syntax
> now just means having to update it again later
> if other predeclared identifiers are added.
>
> russ
>

[dsymonds, 2010-03-16 02:24:24]

complex is in as of the latest release. PTAL?

[rsc, 2010-03-16 03:26:38]

Close.  0x123i is not an imaginary literal.
Imaginary literals are any float followed by i
or decimal string followed by i.
So if these are the floats:

 syn match       goFloat             "\<\d\+\.\d*\([Ee][-+]\d\+\)\?\>"
 syn match       goFloat             "\<\.\d\+\([Ee][-+]\d\+\)\?\>"
 syn match       goFloat             "\<\d\+[Ee][-+]\d\+\>"

then these would be the imaginaries:

 syn match       goFloat             "\<\d\+\.\d*\([Ee][-+]\d\+\)\?i\>"
 syn match       goFloat             "\<\.\d\+\([Ee][-+]\d\+\)\?i\>"
 syn match       goFloat             "\<\d\+[Ee][-+]\d\+i\>"
 syn match       goFloat             "\<\d\+i\>"

Russ

[dsymonds, 2010-03-16 03:30:29]

On Tue, Mar 16, 2010 at 2:26 PM, Russ Cox <rsc@golang.org> wrote:

> Close.  0x123i is not an imaginary literal.
> Imaginary literals are any float followed by i
> or decimal string followed by i.

Done. I've ditched the hexadecimal and octal imaginary literals.


Dave.

[rsc, 2010-03-16 03:33:22]

Looks fine.  I don't know what "hi def link" means but
imaginary seems closer to Float than to Number (== Integer?).

Do you want to change it to Float?  Your call.

Russ

[dsymonds, 2010-03-16 03:35:42]

On Tue, Mar 16, 2010 at 2:33 PM, Russ Cox <rsc@golang.org> wrote:

> Looks fine.  I don't know what "hi def link" means but
> imaginary seems closer to Float than to Number (== Integer?).
>
> Do you want to change it to Float?  Your call.

Roughly, hi def link will link a definition (e.g. goFloat) to a syntax
highlighting class (e.g. Float). It's up to a colorscheme to define
what that actually translates to. I haven't come across a colorscheme
that distinguishes Float and Number, so I'm fine leaving it as-is.

Dave.

[rsc, 2010-03-16 03:38:27]

*** Submitted as http://code.google.com/p/go/source/detail?r=619b9b11434a ***

Add new complex types, functions and literals to Vim syntax file.

R=rsc
CC=golang-dev
http://codereview.appspot.com/224042

Committer: Russ Cox <rsc@golang.org>