Issue 223043: code review 223043: go/ast: streamline representation of field lists

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 223043: code review 223043: go/ast: streamline representation of field lists (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by gri

Modified:
15 years, 1 month ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

go/ast: streamline representation of field lists - always include position information about opening/closing parens/braces - replace uses of []*ast.Field with *ast.FieldList Fixes issue 473.

Patch Set 1 #

Patch Set 2 : code review 223043: go/ast: streamline representation of field lists #

Patch Set 3 : code review 223043: go/ast: streamline representation of field lists #

Patch Set 4 : code review 223043: go/ast: streamline representation of field lists #

Patch Set 5 : code review 223043: go/ast: streamline representation of field lists #

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+151 lines, -115 lines)			Patch
M	src/cmd/cgo/ast.go	View	2	3 chunks	+7 lines, -5 lines	0 comments	Download
M	src/cmd/cgo/gcc.go	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/pkg/exp/eval/typec.go	View		1 chunk	+23 lines, -33 lines	0 comments	Download
M	src/pkg/go/ast/ast.go	View	1	3 chunks	+34 lines, -14 lines	0 comments	Download
M	src/pkg/go/ast/filter.go	View		3 chunks	+13 lines, -6 lines	0 comments	Download
M	src/pkg/go/ast/walk.go	View	1 2	3 chunks	+8 lines, -6 lines	0 comments	Download
M	src/pkg/go/doc/doc.go	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/pkg/go/parser/parser.go	View		7 chunks	+23 lines, -23 lines	0 comments	Download
M	src/pkg/go/printer/nodes.go	View		6 chunks	+20 lines, -21 lines	0 comments	Download
M	src/pkg/go/printer/testdata/comments.golden	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/pkg/go/printer/testdata/comments.input	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gri

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 1 month ago (2010-02-24 23:52:01 UTC) #1

gri

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

15 years, 1 month ago (2010-02-25 00:03:56 UTC) #2

gri

15 years, 1 month ago (2010-02-25 00:17:13 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=69516599069d ***

go/ast: streamline representation of field lists
- always include position information about opening/closing parens/braces
- replace uses of []*ast.Field with *ast.FieldList

Fixes issue 473.

R=rsc
CC=golang-dev
http://codereview.appspot.com/223043

Expand All Messages | Collapse All Messages