code review 2182042: golang.org redesign

golang.org redesign

[r, 2010-09-14 07:15:24]

http://codereview.appspot.com/2182042/diff/1/doc/install.html
File doc/install.html (right):

http://codereview.appspot.com/2182042/diff/1/doc/install.html#newcode102
doc/install.html:102: To perform the next step you must have Mercurial
installed. (Check that you  have an <code>hg</code> command.) This works on most
systems:
s/works/suffices to install Mercurial/

http://codereview.appspot.com/2182042/diff/1/doc/install.html#newcode247
doc/install.html:247: Dive into the Go with the <a href="go_tutorial.html">Go
Tutorial</a>.
dive into the go!!

http://codereview.appspot.com/2182042/diff/1/lib/godoc/godoc.html
File lib/godoc/godoc.html (right):

http://codereview.appspot.com/2182042/diff/1/lib/godoc/godoc.html#newcode15
lib/godoc/godoc.html:15: <h1 id="branding-logo"><a href="/"><span>The Go
Progamming Language - The language for quiet conversation with modern
machines.</span></a></h1>
i thought this was gone

http://codereview.appspot.com/2182042/diff/1/lib/godoc/godoc.html#newcode37
lib/godoc/godoc.html:37: <div id="content">
indentation?

[adg, 2010-09-14 07:23:22]

PTAL

http://codereview.appspot.com/2182042/diff/1/doc/install.html
File doc/install.html (right):

http://codereview.appspot.com/2182042/diff/1/doc/install.html#newcode102
doc/install.html:102: To perform the next step you must have Mercurial
installed. (Check that you  have an <code>hg</code> command.) This works on most
systems:
On 2010/09/14 07:15:25, r wrote:
> s/works/suffices to install Mercurial/

Done.

http://codereview.appspot.com/2182042/diff/1/doc/install.html#newcode247
doc/install.html:247: Dive into the Go with the <a href="go_tutorial.html">Go
Tutorial</a>.
On 2010/09/14 07:15:25, r wrote:
> dive into the go!!

Done.

http://codereview.appspot.com/2182042/diff/1/lib/godoc/godoc.html
File lib/godoc/godoc.html (right):

http://codereview.appspot.com/2182042/diff/1/lib/godoc/godoc.html#newcode15
lib/godoc/godoc.html:15: <h1 id="branding-logo"><a href="/"><span>The Go
Progamming Language - The language for quiet conversation with modern
machines.</span></a></h1>
On 2010/09/14 07:15:25, r wrote:
> i thought this was gone

Done.

http://codereview.appspot.com/2182042/diff/1/lib/godoc/godoc.html#newcode37
lib/godoc/godoc.html:37: <div id="content">
On 2010/09/14 07:15:25, r wrote:
> indentation?

Done.

[rsc, 2010-09-14 14:37:09]

I'm uncomfortable with having two different but
very similar install pages and keeping them up
to date.  Is it possible to make the install.html
page be as brief as the quick start one but with

[more]

tags that expand to add the things that
were dropped?

Russ

[adg, 2010-09-15 00:20:51]

On 15 September 2010 00:37, Russ Cox <rsc@golang.org> wrote:
> I'm uncomfortable with having two different but
> very similar install pages and keeping them up
> to date.  Is it possible to make the install.html
> page be as brief as the quick start one but with
>
> [more]
>
> tags that expand to add the things that
> were dropped?

That's a good idea. I'll remove the quickstart from this iteration,
and make this a nice-to-have for this launch (otherwise I'll do it for
the next release).

[adg, 2010-09-15 05:51:17]

Hello r, rsc, gri (cc: golang-dev@googlegroups.com, iant, ken2, lvd,
nigeltao_golang, stephenm),

I'd like you to review this change.

[r, 2010-09-15 06:18:58]

http://codereview.appspot.com/2182042/diff/13002/doc/playground.html
File doc/playground.html (right):

http://codereview.appspot.com/2182042/diff/13002/doc/playground.html#newcode5
doc/playground.html:5: The Go Playground is a web service that is run on
golang.org's servers.
s/is run/runs/

golang.org should probably be a link, if only for stylistic reasons

http://codereview.appspot.com/2182042/diff/13002/doc/playground.html#newcode7
doc/playground.html:7: a sandbox, and returns the output.
s/and/then/

http://codereview.appspot.com/2182042/diff/13002/doc/root.html
File doc/root.html (right):

http://codereview.appspot.com/2182042/diff/13002/doc/root.html#newcode48
doc/root.html:48: interpreted language.
indentation?

[adg, 2010-09-15 06:23:25]

http://codereview.appspot.com/2182042/diff/13002/doc/playground.html
File doc/playground.html (right):

http://codereview.appspot.com/2182042/diff/13002/doc/playground.html#newcode5
doc/playground.html:5: The Go Playground is a web service that is run on
golang.org's servers.
On 2010/09/15 06:18:58, r wrote:
> s/is run/runs/
> 
> http://golang.org should probably be a link, if only for stylistic reasons

Done.

http://codereview.appspot.com/2182042/diff/13002/doc/playground.html#newcode7
doc/playground.html:7: a sandbox, and returns the output.
On 2010/09/15 06:18:58, r wrote:
> s/and/then/

Done.

http://codereview.appspot.com/2182042/diff/13002/doc/root.html
File doc/root.html (right):

http://codereview.appspot.com/2182042/diff/13002/doc/root.html#newcode48
doc/root.html:48: interpreted language.
On 2010/09/15 06:18:58, r wrote:
> indentation?

Done.

[gri, 2010-09-15 20:32:45]

FYI.

http://codereview.appspot.com/2182042/diff/11028/lib/godoc/godoc.html
File lib/godoc/godoc.html (right):

http://codereview.appspot.com/2182042/diff/11028/lib/godoc/godoc.html#newcode5
lib/godoc/godoc.html:5: <title>The Go Programming Language</title>
trailing tab

[r, 2010-09-16 01:10:44]

http://codereview.appspot.com/2182042/diff/34002/doc/contrib.html
File doc/contrib.html (right):

http://codereview.appspot.com/2182042/diff/34002/doc/contrib.html#newcode36
doc/contrib.html:36: the Go project.</p>
poor sentence

http://codereview.appspot.com/2182042/diff/34002/doc/docs.html
File doc/docs.html (right):

http://codereview.appspot.com/2182042/diff/34002/doc/docs.html#newcode10
doc/docs.html:10: <a href="go_spec.html">language spec</a>.
work through the tutorial. The language specification has all the details should
you want to explore.

http://codereview.appspot.com/2182042/diff/34002/doc/docs.html#newcode14
doc/docs.html:14: it addresses many common beginner questions.
Once you've learned a little about the language, Effective Go will help you
learn the style and idioms of programming in Go.

http://codereview.appspot.com/2182042/diff/34002/doc/playground.html
File doc/playground.html (right):

http://codereview.appspot.com/2182042/diff/34002/doc/playground.html#newcode7
doc/playground.html:7: The service takes a Go program, compiles, links, and runs
the program inside
s/takes/receives/  or maybe /accepts/

http://codereview.appspot.com/2182042/diff/34002/doc/playground.html#newcode12
doc/playground.html:12: There are limitations to the Go programs that can be run
in the Playground.
s/Go // ?

http://codereview.appspot.com/2182042/diff/34002/doc/playground.html#newcode13
doc/playground.html:13: All programs must be single-threaded (but they may use
many goroutines).
s/All programs/They/

http://codereview.appspot.com/2182042/diff/34002/doc/playground.html#newcode15
doc/playground.html:15: The Playground has the use of a subset of the standard
library
s/has the use of/can access only/

http://codereview.appspot.com/2182042/diff/34002/doc/playground.html#newcode17
doc/playground.html:17: As such, the only communication a Playground program has
to the outside world
s/As such/Therefore/

[adg, 2010-09-16 03:44:39]

http://codereview.appspot.com/2182042/diff/34002/doc/contrib.html
File doc/contrib.html (right):

http://codereview.appspot.com/2182042/diff/34002/doc/contrib.html#newcode36
doc/contrib.html:36: the Go project.</p>
On 2010/09/16 01:10:44, r wrote:
> poor sentence

Fixed.

http://codereview.appspot.com/2182042/diff/34002/doc/docs.html
File doc/docs.html (right):

http://codereview.appspot.com/2182042/diff/34002/doc/docs.html#newcode10
doc/docs.html:10: <a href="go_spec.html">language spec</a>.
On 2010/09/16 01:10:44, r wrote:
> work through the tutorial. The language specification has all the details
should
> you want to explore.

Done.

http://codereview.appspot.com/2182042/diff/34002/doc/docs.html#newcode14
doc/docs.html:14: it addresses many common beginner questions.
On 2010/09/16 01:10:44, r wrote:
> Once you've learned a little about the language, Effective Go will help you
> learn the style and idioms of programming in Go.
> 

Done.

http://codereview.appspot.com/2182042/diff/34002/doc/playground.html
File doc/playground.html (right):

http://codereview.appspot.com/2182042/diff/34002/doc/playground.html#newcode7
doc/playground.html:7: The service takes a Go program, compiles, links, and runs
the program inside
On 2010/09/16 01:10:44, r wrote:
> s/takes/receives/  or maybe /accepts/

Done.

http://codereview.appspot.com/2182042/diff/34002/doc/playground.html#newcode12
doc/playground.html:12: There are limitations to the Go programs that can be run
in the Playground.
On 2010/09/16 01:10:44, r wrote:
> s/Go // ?

Done.

http://codereview.appspot.com/2182042/diff/34002/doc/playground.html#newcode13
doc/playground.html:13: All programs must be single-threaded (but they may use
many goroutines).
On 2010/09/16 01:10:44, r wrote:
> s/All programs/They/

Done.

http://codereview.appspot.com/2182042/diff/34002/doc/playground.html#newcode15
doc/playground.html:15: The Playground has the use of a subset of the standard
library
On 2010/09/16 01:10:44, r wrote:
> s/has the use of/can access only/

Done.

http://codereview.appspot.com/2182042/diff/34002/doc/playground.html#newcode17
doc/playground.html:17: As such, the only communication a Playground program has
to the outside world
On 2010/09/16 01:10:44, r wrote:
> s/As such/Therefore/

Done.

[r, 2010-09-16 03:50:18]

LGTM

http://codereview.appspot.com/2182042/diff/59001/doc/contrib.html
File doc/contrib.html (right):

http://codereview.appspot.com/2182042/diff/59001/doc/contrib.html#newcode35
doc/contrib.html:35: mailing list is for discussing and reviewing code for Go
project.</p>
s/Go/the &/

http://codereview.appspot.com/2182042/diff/59001/doc/playground.html
File doc/playground.html (right):

http://codereview.appspot.com/2182042/diff/59001/doc/playground.html#newcode14
doc/playground.html:14: There are limits on execution time, and CPU and memory
usage.
s/are/are also/

[adg, 2010-09-16 04:01:08]

*** Submitted as http://code.google.com/p/go/source/detail?r=dccad82d23ef ***

golang.org redesign

R=r, rsc, gri
CC=golang-dev, iant, ken2, lvd, nigeltao_golang, stephenm
http://codereview.appspot.com/2182042